create celery worker with inference worker profile#327
Merged
saiatmakuri merged 3 commits intomainfrom Oct 17, 2023
Merged
Conversation
Contributor
|
can you briefly describe what this fixes? |
yixu34
reviewed
Oct 17, 2023
seanshi-scale
approved these changes
Oct 17, 2023
Contributor
seanshi-scale
left a comment
seanshi-scale
left a comment
There was a problem hiding this comment.
lgtm as long as we've tested endpoint builder/inference workers, which I think creating a batch job will end up hitting both
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
The endpoint-builder and celery forwarder both use this celery app sessions instantiations. However, they expect different profiles to be used. Force the celery worker to use the dynamic value in
AWS_PROFILEinstead of the staticprofile_ml_worker.Testing Plan
Create a new deployment in our clusters and launched a batch job. The pods were built correctly and the job succeeded.