add user_id and team_id as log facets#321
Merged
song-william merged 2 commits intomainfrom Oct 13, 2023
Merged
Conversation
yixu34
approved these changes
Oct 13, 2023
ian-scale
approved these changes
Oct 13, 2023
Contributor
ian-scale
left a comment
ian-scale
left a comment
There was a problem hiding this comment.
Looks good to me after you remove the commented lines!
seanshi-scale
approved these changes
Oct 13, 2023
Contributor
seanshi-scale
left a comment
seanshi-scale
left a comment
There was a problem hiding this comment.
lgtm once the commented out code is removed (if we want to remove it)
Contributor
There was a problem hiding this comment.
wonder if a defaultdict works here, although I guess it's probably more effort to get the code into a form where it works with defaultdict
song-william
force-pushed
the
wsong/add-user-facets
branch
from
c109c42 to
eaa600f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
user_idandteam_idas additional log facets. Clean up the log tagging to be a bit more general.Tested
CustomJSONFormatterlocally and saw that request_id, user_id, and team_id are in the logger extras.