Repository navigation
fix(blocks): keep explicit badge colors above utility defaults - #10814
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 7ad42a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
charan-rathore
requested review from
amritk,
cameronrohani and
hwkr
as code owners
October 31, 2026 19:23
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
charan-rathore
temporarily deployed
to
production-netlify
October 31, 2026 19:25 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 31, 2026 19:25 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 31, 2026 19:25 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 31, 2026 19:25 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 31, 2026 19:25 — with
GitHub Actions
Inactive
hanspagel
approved these changes
Nov 2, 2026
Merged
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A badge with
color: '#ffcc00'can still render gray in the API reference. The color is present in--badge-color, but late-loading.scalar-app .bg-b-2and.scalar-app .text-c-2utilities have the same specificity as the scoped.badge-coloredrule and win by source order. The text contrast rule loses too.Small reproduction:
Solution
Use
.badge.badge-coloredfor both explicit-color rules, matching the specificity already used by the badge's themed color variants. This keeps the selected background and derived text contrast above the default utilities, without changing plain badges or adding inline styles or!important.The story covers plain, yellow and black badges. Its browser regression loads consumer utilities after the component styles, so it exercises the source-order collision rather than relying on Storybook's default stylesheet order.
Visual
Actual Vue Badge component with the Blocks stylesheet and light theme, before and after:
Checklist
AI-assisted.
Ticket
Fixes #10793