Repository navigation
fix(api-reference): convert flow-style YAML to JSON on download - #10545
Merged
Merged
Conversation
charan-rathore
requested review from
amritk,
cameronrohani,
hanspagel,
hwkr and
marclave
as code owners
October 8, 2026 06:14
🦋 Changeset detectedLatest commit: be95d57 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
charan-rathore
temporarily deployed
to
production-netlify
October 8, 2026 06:17 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 8, 2026 06:17 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 8, 2026 06:17 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 8, 2026 06:17 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 8, 2026 06:17 — with
GitHub Actions
Inactive
hanspagel
force-pushed
the
fix/flow-yaml-json-download
branch
from
October 8, 2026 08:52
35c0cbe to
c55dadc
Compare
hanspagel
enabled auto-merge (squash)
October 8, 2026 08:53
hanspagel
temporarily deployed
to
production-netlify
October 8, 2026 08:55 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 8, 2026 08:55 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 8, 2026 08:55 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 8, 2026 08:55 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 8, 2026 08:55 — with
GitHub Actions
Inactive
downloadDocument detected JSON with a brace/bracket heuristic, so
flow-style YAML starting with { or [ was exported unchanged when JSON
was requested. Detect JSON by parsing instead, and fall back to the
YAML path for flow-style documents.
Fixes #10541
Signed-off-by: Charan Rathore <[email protected]>
hanspagel
force-pushed
the
fix/flow-yaml-json-download
branch
from
October 8, 2026 09:54
c55dadc to
be95d57
Compare
hanspagel
temporarily deployed
to
production-netlify
October 8, 2026 09:57 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 8, 2026 09:57 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 8, 2026 09:57 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 8, 2026 09:57 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 8, 2026 09:57 — with
GitHub Actions
Inactive
Merged
charan-rathore
added a commit
to charan-rathore/charan-rathore
that referenced
this pull request
Oct 8, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public
downloadDocumenthelper treated any input beginning with{or[as JSON. Flow-style YAML could therefore be downloaded unchanged with a.jsonextension andapplication/jsonMIME type.For example, this complete OpenAPI document is valid YAML:
{openapi: 3.1.0, info: {title: Test, version: 1.0.0}, paths: {}}Before this change, the downloaded content remained YAML and failed
JSON.parse. The helper now verifies JSON by parsing it, so flow-style YAML is converted to valid JSON when JSON is requested. Downloads that need no format conversion preserve their original content.Ticket
Fixes #10541