Repository navigation
fix(snippetz): send the body in http/http1.1 examples for json media types and text bodies - #10510
Merged
hanspagel merged 1 commit intoOct 6, 2026
Conversation
charan-rathore
requested review from
amritk,
cameronrohani,
hanspagel,
hwkr and
marclave
as code owners
October 6, 2026 10:39
🦋 Changeset detectedLatest commit: eb5f00e The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
charan-rathore
temporarily deployed
to
production-netlify
October 6, 2026 10:42 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 6, 2026 10:42 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 6, 2026 10:42 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 6, 2026 10:42 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 6, 2026 10:42 — with
GitHub Actions
Inactive
…types and text bodies
hanspagel
force-pushed
the
fix/snippetz-http11-body-media-types
branch
from
October 6, 2026 12:45
12c71be to
eb5f00e
Compare
hanspagel
temporarily deployed
to
production-netlify
October 6, 2026 12:46 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 6, 2026 12:46 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 6, 2026 12:46 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 6, 2026 12:46 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 6, 2026 12:46 — with
GitHub Actions
Inactive
hanspagel
approved these changes
Oct 6, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The raw HTTP/1.1 code example leaves out the request body unless the media type is exactly
application/json,application/octet-stream, a url-encoded form or multipart. A body forapplication/json; charset=utf-8,application/vnd.api+json,text/plainorapplication/xmlis dropped, so the copied request is sent with aContent-Typeheader and no body.Solution
Use the existing
isJsonMediaTypehelper from@scalar/helpersfor JSON types and keep the media type as written in the header. Any other body that has text is now sent as it is. Output for plainapplication/jsonis the same as before.I added tests for a charset parameter, a
+jsontype and a plain text body. All three fail without the change.Checklist