Repository navigation
fix(snippetz): keep multiline strings and odd names valid in clj-http examples - #10507
Merged
hanspagel merged 1 commit intoOct 6, 2026
Merged
Conversation
charan-rathore
requested review from
amritk,
cameronrohani,
hanspagel,
hwkr and
marclave
as code owners
October 6, 2026 09:49
🦋 Changeset detectedLatest commit: 63f2f87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
charan-rathore
temporarily deployed
to
production-netlify
October 6, 2026 09:52 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 6, 2026 09:52 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 6, 2026 09:52 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 6, 2026 09:52 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 6, 2026 09:52 — with
GitHub Actions
Inactive
hanspagel
force-pushed
the
fix/snippetz-clj-http-multiline
branch
from
October 6, 2026 10:29
ad30e98 to
63f2f87
Compare
hanspagel
temporarily deployed
to
production-netlify
October 6, 2026 10:32 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 6, 2026 10:32 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 6, 2026 10:32 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 6, 2026 10:32 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 6, 2026 10:32 — with
GitHub Actions
Inactive
hanspagel
approved these changes
Oct 6, 2026
charan-rathore
added a commit
to charan-rathore/charan-rathore
that referenced
this pull request
Oct 6, 2026
Merged
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two things make the clj-http code example wrong or invalid Clojure:
X Customorfilter[name]gives:X Custom, which is not valid Clojure.Solution
Write line breaks as
\nand\rescapes, so the layout padding can never end up inside a string. Names that are not valid keywords are written as string keys, which clj-http accepts for headers, query params and form params. Normal names still render as:name.One existing test expected
:special chars!@#, which is not valid Clojure, so I updated it to"special chars!@#". I added tests for a multiline text body, a multiline JSON value and header and query names with spaces and brackets. They fail without the fix.Checklist