Repository navigation
fix(snippetz): escape strings in C# HttpClient code examples - #10503
Merged
hanspagel merged 2 commits intoOct 6, 2026
Merged
Conversation
charan-rathore
requested review from
amritk,
cameronrohani,
hanspagel,
hwkr and
marclave
as code owners
October 5, 2026 22:44
🦋 Changeset detectedLatest commit: 9ac4f82 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
charan-rathore
temporarily deployed
to
production-netlify
October 5, 2026 22:48 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 5, 2026 22:48 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 5, 2026 22:48 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 5, 2026 22:48 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 5, 2026 22:48 — with
GitHub Actions
Inactive
Signed-off-by: Charan Rathore <[email protected]>
hanspagel
force-pushed
the
fix/snippetz-csharp-httpclient-escape
branch
from
October 6, 2026 09:31
9eddbcc to
9ac4f82
Compare
hanspagel
temporarily deployed
to
production-netlify
October 6, 2026 09:34 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 6, 2026 09:34 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 6, 2026 09:34 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 6, 2026 09:34 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 6, 2026 09:34 — with
GitHub Actions
Inactive
hanspagel
approved these changes
Oct 6, 2026
Merged
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The C#
HttpClientcode example writes some values into C# string literals without escaping them, so the copied code does not compile or sends different data:Authorizationscheme or token, or form field that contains a double quote or backslash breaks the string literal.\or a new line was written wrongly.Acceptvalues and multipart content types.Solution
Use the existing
escapeCSharpStringhelper for these values, and make it escape carriage returns and new lines too. JSON and text bodies still use the raw string literal, so their output is unchanged.I added tests for a URL, headers, cookie and form fields with quotes and backslashes, and for an octet-stream body with a backslash and a line break. Both fail without the fix.
Checklist