Repository navigation
fix(snippetz): escape quotes and backslashes in php/curl request bodies - #10495
Merged
hanspagel merged 1 commit intoOct 6, 2026
Merged
Conversation
charan-rathore
requested review from
amritk,
cameronrohani,
hanspagel,
hwkr and
marclave
as code owners
October 5, 2026 20:02
🦋 Changeset detectedLatest commit: 7c4f871 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
charan-rathore
temporarily deployed
to
production-netlify
October 5, 2026 20:05 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 5, 2026 20:05 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 5, 2026 20:05 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 5, 2026 20:05 — with
GitHub Actions
Inactive
charan-rathore
temporarily deployed
to
production-netlify
October 5, 2026 20:05 — with
GitHub Actions
Inactive
Signed-off-by: Charan Rathore <[email protected]>
hanspagel
force-pushed
the
fix/snippetz-php-curl-escape-body
branch
from
October 6, 2026 09:31
aa37068 to
7c4f871
Compare
hanspagel
temporarily deployed
to
production-netlify
October 6, 2026 09:33 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 6, 2026 09:33 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 6, 2026 09:33 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 6, 2026 09:33 — with
GitHub Actions
Inactive
hanspagel
temporarily deployed
to
production-netlify
October 6, 2026 09:33 — with
GitHub Actions
Inactive
hanspagel
approved these changes
Oct 6, 2026
Merged
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The PHP cURL code example puts request bodies inside a single quoted PHP string without escaping them. If a plain text body, an octet-stream body, or a JSON body that can't be parsed contains an apostrophe or a backslash, the generated code is not valid PHP. For example, the text
it's finebecomes'it's fine', which is a syntax error when a user copies it.Other PHP targets (guzzle, laravel) already escape these values.
Solution
Use the existing
objectToStringhelper fromlibs/phpfor these three body paths. It escapes backslashes and single quotes, the same way the guzzle and laravel examples do. Output for normal bodies does not change.I added tests for a plain text body, an unparsable JSON body and an octet-stream body. All three fail without the fix.
Checklist