improvement: Upload zip to limit download sizes #4847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
force-pushed
the
upload-zips
branch
4 times, most recently
from
c512e71 to
6a7390e
Compare
kitbellew
requested changes
Feb 24, 2025
.github/workflows/release-native.yml
Outdated
Comment on lines
47
to
52
| - name: Zip artifact for deployment | ||
| if: ${{ !startsWith(matrix.deploy.os, 'windows') }} | ||
| run: zip ${{ matrix.deploy.name }} ${{ env.BINARY_NAME }} | ||
| - name: Zip artifact for deployment | ||
| if: ${{ startsWith(matrix.deploy.os, 'windows') }} | ||
| run: 7z a ${{ matrix.deploy.name }} ${{ env.BINARY_NAME }} |
Collaborator
There was a problem hiding this comment.
one rule, perhaps:
- name: Zip ...
run: ${{
startsWith(matrix.deploy.os, 'windows') &&
7z matrix.deploy.name 'scalafmt.exe' ||
zip matrix.deploy.name 'scalafmt'
}}
and remove definition of BINARY_NAME under env.
Contributor
Author
There was a problem hiding this comment.
I couldn't make it work like this, but I removed BINARY_NAME let me know what you think
Collaborator
There was a problem hiding this comment.
sounds good, approved. perhaps we can't construct argv within ${{ }}, or perhaps we just need to use quotes, like ${{ '7z' 'a' matrix.deploy.name 'scalafmt.exe' }}...
Contributor
Author
There was a problem hiding this comment.
I tried that as well and unless there is something else to change I don't think that will work. It actually reported the previous line without any data.
tgodzik
force-pushed
the
upload-zips
branch
6 times, most recently
from
1f22fe8 to
7abbfb4
Compare
kitbellew
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.