PlatformFileOps: read/write files asynchronously #4822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbellew
force-pushed
the
4822
branch
2 times, most recently
from
79bda26 to
9fc3447
Compare
|
Just curious... Did you notice any performance improvements? Would be great. It takes a while to check formatting in a large code base... |
Collaborator
Author
Not really. The build includes community-test checks, and they take about the same time. But they are not slower, and someone might suggest additional tuning. The main purpose is to use the same design for all three platforms, and scala.js, apparently, is inherently asynchronous. |
kitbellew
force-pushed
the
4822
branch
2 times, most recently
from
ade6a5e to
25e8a8f
Compare
Previously, we simply wrapped a Future around a blocking file I/O both on JVM and Native; while we still keep this approach on Native, let's implement actual asynchronous file I/O on JVM, just like on JS. Also, modify runners to use this async writing and a different thread pool for that, so that it does not clash with formatting tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we simply wrapped a Future around a blocking file I/O both on JVM and Native; while we still keep this approach on Native, let's implement actual asynchronous file I/O on JVM, just like on JS.
Also, modify runners to use this async writing and a different thread pool for that, so that it does not clash with formatting tasks.