Skip to content

MarkdownPart: identify mdoc code fence modifier#818

Merged
tgodzik merged 1 commit intoscalameta:mainfrom
kitbellew:818
Nov 5, 2023
Merged

MarkdownPart: identify mdoc code fence modifier#818
tgodzik merged 1 commit intoscalameta:mainfrom
kitbellew:818

Conversation

@kitbellew
Copy link
Copy Markdown
Contributor

No description provided.

@kitbellew kitbellew requested a review from tgodzik November 3, 2023 14:39
@tgodzik
Copy link
Copy Markdown
Contributor

tgodzik commented Nov 3, 2023

Looks like tests.markdown.MultiModsSuite is failing, could you take a look?

@kitbellew
Copy link
Copy Markdown
Contributor Author

@tgodzik fixed, thank you.

@tgodzik tgodzik merged commit d7b59fb into scalameta:main Nov 5, 2023
@kitbellew kitbellew deleted the 818 branch November 5, 2023 17:46
@kitbellew
Copy link
Copy Markdown
Contributor Author

@tgodzik will you be able to release it sometime soon? you said something about a new JDK.

@tgodzik
Copy link
Copy Markdown
Contributor

tgodzik commented Nov 6, 2023

Yes, some of the libraries stopped supporting JDK 8 so we needed to start releasing with JDK 11, which might be problematic if someone still needs to use JDK 8. Although, in those cases they should be fine to just stay with the particular version.

@tgodzik
Copy link
Copy Markdown
Contributor

tgodzik commented Nov 6, 2023

Anyway, I can do a release today if there is nothing else you would like to include?

@kitbellew
Copy link
Copy Markdown
Contributor Author

@tgodzik no, I wasn't planning to add anything yet, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants