Skip to content

Conversation

@mkurz
Copy link
Contributor

@mkurz mkurz commented Dec 13, 2025

@tgodzik You just need to merge this PR and tag 3.2.1. I also already bumped the snapshot version to 3.2.2 for that.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ach, thanks for investigating and the fix!

@tgodzik tgodzik merged commit f432021 into scalacenter:main Dec 15, 2025
6 checks passed
@mkurz mkurz deleted the fix_action.yml branch December 15, 2025 11:59
@mkurz
Copy link
Contributor Author

mkurz commented Dec 15, 2025

Happy to help!

@mkurz
Copy link
Contributor Author

mkurz commented Dec 15, 2025

Another thing: It seems that you create a GitHub release, which then creates the tag for you, which then triggers the actual release: https://github.com/scalacenter/sbt-dependency-submission/actions/runs/20231329008.

I recommend to locally tag the release, push the tag, wait for the successful CI pipeline until the artifacts hit maven central and only afterwards create the GitHub release from the then already exsting tag. Because if ci fails, you end up having the release announced on GitHub, with people getting notified - but the artifacts can't be fetched as they are not published (even if you do another release afterwards, IMHO it's bad practise to have a GitHub release page in the archive that does not actually exist)

Just my 2 cents, because I have done the same in the past until I realized that process has flaws.
And sorry for trying to be too smart here ;)

@tgodzik
Copy link
Contributor

tgodzik commented Dec 15, 2025

You're probably right here, it's just convenient to do it this way. I'll do it the other way around later.

@mkurz
Copy link
Contributor Author

mkurz commented Dec 15, 2025

@tgodzik Can you also force push the v3 tag again? Thanks for all your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants