Fix #3408: Implement two javalib static String join() methods. #3420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeTibbert
added
component:javalib
backport candidate
tanishiking
approved these changes
Aug 9, 2023
Member
tanishiking
left a comment
tanishiking
left a comment
There was a problem hiding this comment.
One nit comment, but otherwise it looks good from my side :)
| import java.nio._ | ||
| import java.nio.charset._ | ||
| import java.util.Objects | ||
| import java.util.{Objects, Arrays} |
Member
There was a problem hiding this comment.
Unused import?
Suggested change
| import java.util.{Objects, Arrays} | |
| import java.util.Objects |
Contributor
Author
There was a problem hiding this comment.
Thank you for the review & suggestion. Good to have a second pair of eyes.
WojciechMazur
pushed a commit
to WojciechMazur/scala-native
that referenced
this pull request
Sep 1, 2023
…hods. (scala-native#3420) * Fix scala-native#3408: Implement two javalib static String join() methods. (cherry picked from commit b54e069)
WojciechMazur
pushed a commit
that referenced
this pull request
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3408
Implement javalib static String join() methods & corresponding Tests.
This implementation uses the new
StringJoinercode.