Wasm: Implement fmod on the Wasm side. #5147
Closed
+677
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They contain groups of instructions by Wasm type, so that it is easier to generically write algorithms over multiple primitive types. We use them for the implementations of signed division and modulo on integers.
This avoids the JS call overhead for that "primitive" operation. As can be seen in the implementation, `fmod` is far from a primitive, though. We took an MIT implemention of `fmod`, generic in the bit-width, and translated it by hand to Wasm. We use the newly introduced `GenericInstructions` to also have a generic implementation. So we generate one function for `Float_%` and one for `Double_%`.
This was referenced Mar 25, 2025
Member
Author
|
#5149 is probably a better alternative. |
Member
Author
|
Superseded by #5149. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the JS call overhead for that "primitive" operation.
As can be seen in the implementation,
fmodis far from a primitive, though. We took an MIT implemention offmod, generic in the bit-width, and translated it by hand to Wasm. We use the newly introducedGenericInstructionsto also have a generic implementation. So we generate one function forFloat_%and one forDouble_%./cc @tanishiking This also removes the dependency on JS for that operation, which will be useful to compile to Wasm-without-JS-host.