Upgrade to ASM 7.0 #5905
Merged
Upgrade to ASM 7.0 #5905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Catch up with Scala 2.13. The corresponding scalac PRs are scala/scala#6733 and scala/scala#7384 Some of the changes from these PRs aren't currently needed in Dotty since they only affect the Scala 2 backend optimizer. This update does not change the generated bytecode (at least when compiling dotty itself). Co-Authored-By: Jason Zaugg <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/5905/ to see the changes. Benchmarks is based on merging with master (58b8aaa) |
This comment has been minimized.
This comment has been minimized.
1 similar comment
Member
|
performance test scheduled: 3 job(s) in queue, 1 running. |
Member
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/5905/ to see the changes. Benchmarks is based on merging with master (58b8aaa) |
Otherwise the tastyBootstrap test failed when compiling the .java files added in the previous commit that depend on scala-asm.
nicolasstucki
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to ASM 7.0
Catch up with Scala 2.13.
The corresponding scalac PRs are
scala/scala#6733 and
scala/scala#7384
Some of the changes from these PRs aren't currently needed in Dotty
since they only affect the Scala 2 backend optimizer.
This update does not change the generated bytecode (at least when
compiling dotty itself).
Co-Authored-By: Jason Zaugg [email protected]