Support use-site meta-annotations #16445
Conversation
|
Doesn't have a test for #15318 actually, and looking at it it uses |
Co-Authored-By: Guillaume Martres <[email protected]>
dwijnand
force-pushed
the
meta-annotations
branch
from
3a3ecf7 to
6d3ee4a
Compare
|
Next to fix the symbol positions of the copied annotations under -Ytest-pickler......... |
dwijnand
force-pushed
the
meta-annotations
branch
from
4bf54d5 to
48a7d11
Compare
sjrd
left a comment
sjrd
left a comment
There was a problem hiding this comment.
There is a removeUnwantedAnnotations in Memoize.scala as well. Should it be affected?
dwijnand
force-pushed
the
meta-annotations
branch
from
aa1bc24 to
fa6326a
Compare
| !annotSym.annotations.exists(metaAnnot => defn.FieldAccessorMetaAnnots.contains(metaAnnot.symbol)) | ||
| }) | ||
| annot.hasOneOfMetaAnnotation(metaAnnotSym, metaAnnotSymBackup) | ||
| || keepIfNoRelevantAnnot && !annot.hasOneOfMetaAnnotation(defn.NonBeanMetaAnnots.toList*) |
There was a problem hiding this comment.
Why exclude "bean" meta annotations here?
There was a problem hiding this comment.
This runs before bean getters and setters are created. So if we lose the @beanGetter/@beanSetter-annotated annotations on the regular class vals, e.g.:
@(JsonProperty @beanGetter) @BeanProperty val beanGet: String = ""Then they'll never be copied over onto the def getBeanGet: String = ... we're about to syntheses.
There was a problem hiding this comment.
In Memoize, where we split vals into fields and re-written getters/setters, we now also drop annotations that are beanGetter/Setter annotated, from the field, and keep only @getter/@setter-annotated annotations on the (non-bean) getters/setters.
Workaround issue with annotations covered by scala/scala3#12492, fixed with scala/scala3#16445 This commit can be reverted as soon as the fix is released (according to https://github.com/lampepfl/dotty/releases this is not yet the case)
Workaround issue with annotations covered by scala/scala3#12492, fixed with scala/scala3#16445 This commit can be reverted as soon as the fix is released (according to https://github.com/lampepfl/dotty/releases this is not yet the case)
Workaround issue with annotations covered by scala/scala3#12492, fixed with scala/scala3#16445 This commit can be reverted as soon as the fix is released (according to https://github.com/lampepfl/dotty/releases this is not yet the case)
5 participants
Fixes #12492
Fixes #15318