Skip to content

Fix reflect typeMembers to return all members#15033

Merged
smarter merged 2 commits intoscala:mainfrom
dotty-staging:fix-14902
Nov 23, 2022
Merged

Fix reflect typeMembers to return all members#15033
smarter merged 2 commits intoscala:mainfrom
dotty-staging:fix-14902

Conversation

@nicolasstucki
Copy link
Copy Markdown
Contributor

@nicolasstucki nicolasstucki commented Apr 26, 2022

Fixes #14902

@pikinier20
Copy link
Copy Markdown
Contributor

pikinier20 commented Apr 26, 2022

I've pushed a commit repairing Scaladoc tests

@nicolasstucki
Copy link
Copy Markdown
Contributor Author

nicolasstucki commented Apr 26, 2022

I've pushed a commit repairing Scaladoc tests

Did not notice this commit and force pushed the fix I had. @pikinier20 is this the same fix that you did?

@pikinier20
Copy link
Copy Markdown
Contributor

pikinier20 commented Apr 26, 2022

I've pushed a commit repairing Scaladoc tests

Did not notice this commit and force pushed the fix I had. @pikinier20 is this the same fix that you did?

Yes, it is. Sorry for messing up :)

pikinier20
pikinier20 reviewed Apr 26, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@pikinier20 pikinier20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in Scaladoc are fine. However, I'm not a person who can approve changes in compiler API.

@pikinier20 pikinier20 removed their assignment Apr 26, 2022
@nicolasstucki nicolasstucki requested a review from smarter April 26, 2022 15:12
@nicolasstucki
Copy link
Copy Markdown
Contributor Author

nicolasstucki commented Apr 26, 2022

Note that the other fixes in the documentation are in #15034

smarter
smarter requested changes Apr 26, 2022
View reviewed changes
Comment thread compiler/src/scala/quoted/runtime/impl/QuotesImpl.scala Outdated
Comment thread compiler/src/scala/quoted/runtime/impl/QuotesImpl.scala Outdated
@smarter smarter assigned nicolasstucki and unassigned smarter Apr 26, 2022
smarter
smarter reviewed Nov 17, 2022
View reviewed changes
Comment thread compiler/src/scala/quoted/runtime/impl/QuotesImpl.scala Outdated
def memberType(name: String): Symbol = typeMember(name)
def typeMember(name: String): Symbol =
def memberType(name: String): Symbol =
self.unforcedDecls.find(sym => sym.name == name.toTypeName)
Copy link
Copy Markdown
Member

@smarter smarter Nov 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this was present before, but any reason we use unforcedDecls here? That could also miss declarations.

Copy link
Copy Markdown
Contributor Author

@nicolasstucki nicolasstucki Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not belive there was a particular reason. Which method would you use instead?

Copy link
Copy Markdown
Member

@smarter smarter Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decls

Copy link
Copy Markdown
Contributor Author

@nicolasstucki nicolasstucki Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@smarter smarter merged commit c9ace66 into scala:main Nov 23, 2022
@smarter smarter deleted the fix-14902 branch November 23, 2022 13:11
@xerial xerial mentioned this pull request May 23, 2023
Merged
xerial added a commit to wvlet/airframe that referenced this pull request May 23, 2023
@xerial
airframe-surface: Use the fixed declaredTypes in Scala 3.3.0 scala/sc…
169206c 
…ala3#15033
@Kordyjan Kordyjan added this to the 3.3.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarter smarter smarter approved these changes

+1 more reviewer

@pikinier20 pikinier20 pikinier20 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@smarter smarter

Labels

None yet

Projects

None yet

Milestone

3.3.0

Development

Successfully merging this pull request may close these issues.

Can't get inherited types from Quotes

4 participants

@nicolasstucki @pikinier20 @smarter @Kordyjan