Add reflect `ClassDef.apply` and `Symbol.newClass` by nicolasstucki · Pull Request #14124 · scala/scala3

nicolasstucki · 2021-12-17T10:43:37Z

We also add

SymbolMethods.typeRef
SymbolMethods.termRef
TypeTreeModule.ref

smarter

Otherwise LGTM.

smarter · 2022-03-02T12:16:53Z

+
+  val cls = Symbol.newClass(Symbol.spliceOwner, name, parents = Nil, decls, selfInfo = None)
+  val clsDef = ClassDef(cls, parents, body = List())
+  val newCls = Typed(Apply(Select(New(TypeIdent(cls)), cls.primaryConstructor), Nil), TypeTree.of[Object])


I guess this is orthogonal but in tpd we have a New overload that takes constructor arguments this could be useful here too

smarter · 2022-03-16T14:37:44Z

+         *  @pre symbol.isType returns true
+         */
+        @experimental
+        def typeRef: TypeRef


It seems that we're missing an API to create a TypeRef/TermRef from a specific prefix: with foo.typeRef I can get a TypeRef this.foo and with pre.memberType(foo) I can get the info corresponding to pre.foo, but is there a way to generate the TypeRef pre.foo itself?

Doesn't TypeRepr.select provide that?

Oh indeed, I missed that one, maybe each of their documentation should @see the other one.

smarter · 2022-03-16T14:42:40Z

+ */
+def makeFooBar(using Quotes)(name: String, fooCls: quotes.reflect.Symbol): quotes.reflect.ClassDef = {
+  import quotes.reflect.*
+  val parents = List(Inferred(fooCls.typeRef), TypeTree.of[Bar])


Perhaps instead of the Inferred(foo.typeRef) pattern we could have an overload of TypeTree.apply (or TypeTree.of? Not sure why we use of there) that takes a Symbol. This would be similar to the compiler-internal tpd.ref (in fact alternatively we could expose ref directly?)

~~Added TypeTree.apply~~ Added TypeTree.ref.

We should probably add TypeTree.apply as an alias of Inferred.apply. We cannot overload this method.

smarter

Otherwise LGTM!

evbo · 2022-07-22T16:09:37Z

@nicolasstucki thank you for this!!! I am noticing a class cast exception if I try pattern matching typeRef you added in this PR:

java.lang.ClassCastException: class dotty.tools.dotc.core.Names$SimpleName cannot be cast to class dotty.tools.dotc.core.Names$TypeName (dotty.tool
s.dotc.core.Names$SimpleName and dotty.tools.dotc.cor
e.Names$TypeName are in unnamed module of loader sbt.
internal.classpath.ClassLoaderCache$Key$CachedClassLo
ader @2c470fec)

e.g. if I try to check the type of a case class field like:

// scala 3.2.0-RC2
declaredField.companionClass.caseFields.map { ccField =>
  val tt = ccField.typeRef match {
    case TypeRef(typeRepr, args) => s"args are: ${args}"
  }
}

I wasn't sure if this was a separate bug or not, happy to open a new one. It does seem odd seeing that exception; feels like a class cast exception happening internally so thought it might be important.

Update: I've found this and while I'm still not sure about that class cast exception above, it does seem to be the case that matching on AppliedType will yield the type args

nicolasstucki added the stat:wip label Dec 17, 2021

nicolasstucki self-assigned this Jan 13, 2022

nicolasstucki force-pushed the add-reflect-ClassDef-apply branch 2 times, most recently from 8bc0c20 to 1fbda34 Compare February 18, 2022 09:08

nicolasstucki mentioned this pull request Feb 18, 2022

Remove unnecessary newScope in newNormalizedClassSymbol #14512

Merged

nicolasstucki force-pushed the add-reflect-ClassDef-apply branch 3 times, most recently from 647629e to 24586e1 Compare February 22, 2022 11:09

nicolasstucki removed the stat:wip label Feb 26, 2022

nicolasstucki force-pushed the add-reflect-ClassDef-apply branch 2 times, most recently from 7def96e to d32d4af Compare February 28, 2022 08:23

nicolasstucki marked this pull request as ready for review February 28, 2022 12:07

nicolasstucki requested a review from smarter February 28, 2022 12:07

nicolasstucki assigned smarter and unassigned nicolasstucki Feb 28, 2022

smarter requested changes Feb 28, 2022

View reviewed changes

Comment thread compiler/src/scala/quoted/runtime/impl/QuotesImpl.scala Outdated

Comment thread library/src/scala/quoted/Quotes.scala Outdated

Comment thread library/src/scala/quoted/Quotes.scala

smarter assigned nicolasstucki and unassigned smarter Feb 28, 2022

nicolasstucki changed the title ~~Add reflect class def apply~~ Add reflect ClassDef.apply and Symbol.newClass Mar 2, 2022

nicolasstucki added the release-notes Should be mentioned in the release notes label Mar 2, 2022

nicolasstucki force-pushed the add-reflect-ClassDef-apply branch 2 times, most recently from 2254fa4 to 4845353 Compare March 2, 2022 08:13

nicolasstucki added release-notes Should be mentioned in the release notes and removed release-notes Should be mentioned in the release notes labels Mar 2, 2022

nicolasstucki assigned smarter and unassigned nicolasstucki Mar 2, 2022

smarter requested changes Mar 2, 2022

View reviewed changes

smarter reviewed Mar 2, 2022

View reviewed changes

Comment thread library/src/scala/quoted/Quotes.scala Outdated

smarter reviewed Mar 2, 2022

View reviewed changes

Comment thread library/src/scala/quoted/Quotes.scala Outdated

smarter reviewed Mar 2, 2022

View reviewed changes

Comment thread library/src/scala/quoted/Quotes.scala Outdated

nicolasstucki force-pushed the add-reflect-ClassDef-apply branch 2 times, most recently from 072c154 to 4800912 Compare March 16, 2022 12:19

smarter requested changes Mar 16, 2022

View reviewed changes

nicolasstucki force-pushed the add-reflect-ClassDef-apply branch 5 times, most recently from d0bb8b6 to cf0b09e Compare March 22, 2022 14:53

nicolasstucki assigned smarter and unassigned nicolasstucki Mar 23, 2022

nicolasstucki force-pushed the add-reflect-ClassDef-apply branch 3 times, most recently from a0d7004 to 26bb201 Compare March 23, 2022 15:48

smarter approved these changes Mar 23, 2022

View reviewed changes

Comment thread library/src/scala/quoted/Quotes.scala Outdated

smarter assigned nicolasstucki and unassigned smarter Mar 23, 2022

Add reflect ClassDef.apply and Symbol.newClass

36853ff

nicolasstucki force-pushed the add-reflect-ClassDef-apply branch from 26bb201 to 36853ff Compare March 24, 2022 07:16

nicolasstucki enabled auto-merge March 24, 2022 07:17

nicolasstucki merged commit a5d5fe5 into scala:main Mar 24, 2022

nicolasstucki deleted the add-reflect-ClassDef-apply branch March 24, 2022 08:39

smarter mentioned this pull request Apr 20, 2022

Quotes: generate arbitrary trait or class implementations #11685

Closed

This was referenced May 27, 2022

airframe-grpc: Fix syntax for Scala 3 wvlet/airframe#2193

Merged

airframe-http-router/grpc: Scala 3 support wvlet/airframe#2194

Closed

neko-kai mentioned this pull request May 30, 2022

Resurrect proposed Fix #13553: add Symbol#tpe method #13826

Closed

evbo mentioned this pull request Jul 22, 2022

Expand case class default values example lampepfl/dotty-macro-examples#32

Open

Kordyjan added this to the 3.1.3 milestone Aug 1, 2023

This was referenced Sep 5, 2023

Update scala3-staging, ... to 3.3.1 wvlet/airframe#3194

Closed

Cannot use experimental language features in @experimental code #13392

Closed

Conversation

nicolasstucki commented Dec 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smarter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smarter Mar 2, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smarter Mar 16, 2022

Choose a reason for hiding this comment

Uh oh!

nicolasstucki Mar 22, 2022

Choose a reason for hiding this comment

Uh oh!

smarter Mar 22, 2022

Choose a reason for hiding this comment

Uh oh!

nicolasstucki Mar 23, 2022

Choose a reason for hiding this comment

Uh oh!

smarter Mar 16, 2022

Choose a reason for hiding this comment

Uh oh!

nicolasstucki Mar 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smarter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

evbo commented Jul 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nicolasstucki commented Dec 17, 2021 •

edited

Loading

nicolasstucki Mar 22, 2022 •

edited

Loading

evbo commented Jul 22, 2022 •

edited

Loading