Skip to content

Upgrade Scala.js to 1.0.0#300

Merged
julienrf merged 2 commits intoscala:masterfrom
xerial:scalajs1.0.0
Feb 5, 2020
Merged

Upgrade Scala.js to 1.0.0#300
julienrf merged 2 commits intoscala:masterfrom
xerial:scalajs1.0.0

Conversation

@xerial
Copy link
Copy Markdown
Contributor

@xerial xerial commented Feb 5, 2020

@xerial
Copy link
Copy Markdown
Contributor Author

xerial commented Feb 5, 2020

Looks like there is a bootstrap issue: for building scala-collection-compat, we need the version 2.1.3 built for Scala.js 1.0.0.

@xerial
Copy link
Copy Markdown
Contributor Author

xerial commented Feb 5, 2020

By setting a git tag (e.g., v2.1.4 for sbt-dynver), all tests (sbt test) worked on my local machine.

@xerial xerial requested a review from julienrf February 5, 2020 18:29
@julienrf
Copy link
Copy Markdown
Contributor

julienrf commented Feb 5, 2020

@xerial
Copy link
Copy Markdown
Contributor Author

xerial commented Feb 5, 2020

@julienrf Thanks. Added a temporary workaround to pass the CI

@julienrf julienrf merged commit 3d98110 into scala:master Feb 5, 2020
@sjrd
Copy link
Copy Markdown
Member

sjrd commented Feb 7, 2020

Thanks for the PR and for merging it.

Who can do the necessary steps to publish a version with 1.0.0 support? Some other libraries in the ecosystem are blocked by scala-collection-compat.

@SethTisue
Copy link
Copy Markdown
Member

@julienrf are you planning to do a release shortly? if not, I can attempt it

@julienrf
Copy link
Copy Markdown
Contributor

julienrf commented Feb 9, 2020 via email

@julienrf
Copy link
Copy Markdown
Contributor

It seems that the release process went smoothly! Please let me know if something doesn’t work as expected. https://github.com/scala/scala-collection-compat/releases/tag/v2.1.4

@xerial
Copy link
Copy Markdown
Contributor Author

xerial commented Feb 10, 2020

@julienrf I still can't find 2.1.4 jar files for sjs1.0 in https://repo1.maven.org/maven2/org/scala-lang/modules/

Did you close and promote the staging artifacts at Sonatype? If you did that, we may need to wait for more hours until the artifacts will be synchronized at Sonatype.

@lrytz
Copy link
Copy Markdown
Member

lrytz commented Feb 10, 2020

@xerial @julienrf I just released the staging repos, the artifacts will hopefully be on maven central soon.

@xerial
Copy link
Copy Markdown
Contributor Author

xerial commented Feb 10, 2020

Thanks! The artifacts are now available on Maven central.
cc: @sjrd

@xerial xerial deleted the scalajs1.0.0 branch February 10, 2020 15:49
@xerial
Copy link
Copy Markdown
Contributor Author

xerial commented Feb 10, 2020

@lrytz 2.1.4 for Scala 2.12 is still missing. https://repo1.maven.org/maven2/org/scala-lang/modules/scala-collection-compat_2.12/

A weird thing is 2.1.4 for Scala 2.11/2.13 is available

@julienrf
Copy link
Copy Markdown
Contributor

julienrf commented Feb 10, 2020

@SethTisue
Copy link
Copy Markdown
Member

there are no leftover staging repositories :-/

@xerial
Copy link
Copy Markdown
Contributor Author

xerial commented Feb 11, 2020

The above CI log only shows closing step. It looks like 2.1.4 for Scala 2.12 has never been promoted (sonatypePromote) or dropped before sonatypePromote step.

@lrytz
Copy link
Copy Markdown
Member

lrytz commented Feb 11, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants