Skip to content

Build for Scala.js 1.0.0-RC1#268

Merged
julienrf merged 5 commits intoscala:masterfrom
xerial:patch-1
Nov 26, 2019
Merged

Build for Scala.js 1.0.0-RC1#268
julienrf merged 5 commits intoscala:masterfrom
xerial:patch-1

Conversation

@xerial
Copy link
Copy Markdown
Contributor

@xerial xerial commented Nov 22, 2019

No description provided.

@xerial xerial mentioned this pull request Nov 22, 2019
Merged
4 tasks
@julienrf
Copy link
Copy Markdown
Contributor

julienrf commented Nov 22, 2019

It looks like we should disable mima when building for Scala.js 1.0.0-RC1

@xerial
Copy link
Copy Markdown
Contributor Author

xerial commented Nov 23, 2019

I don't know why, but Travis CI environment is broken.

@lrytz
Copy link
Copy Markdown
Member

lrytz commented Nov 23, 2019

cleared the travis caches and re-started the builds (cause: same as scala/scala#8528), the results should be acurate now.

julienrf
julienrf reviewed Nov 25, 2019
View reviewed changes
Comment thread build.sbt Outdated
@xerial
Copy link
Copy Markdown
Contributor Author

xerial commented Nov 25, 2019

Applied the suggested fixes. At least, compatXXXJs/tests worked in my machine.

@julienrf
Copy link
Copy Markdown
Contributor

julienrf commented Nov 25, 2019

Could you please sign the Scala CLA?
https://www.lightbend.com/contribute/cla/scala

@xerial
Copy link
Copy Markdown
Contributor Author

xerial commented Nov 25, 2019

I think I have already signed to that, but let me double check.

@xerial
Copy link
Copy Markdown
Contributor Author

xerial commented Nov 25, 2019

Signing is done.

@julienrf
Copy link
Copy Markdown
Contributor

julienrf commented Nov 25, 2019

Thanks @xerial! It seems that something is wrong with the CLA system… Does anyone have an idea of what we can do? (@lrytz or @SethTisue?)

@lrytz
Copy link
Copy Markdown
Member

lrytz commented Nov 26, 2019

checkCLA.sh does

curl -u dummy4dummy:dummy2dummy -s "https://api.github.com/repos/scala/scala-collection-compat/pulls/268"

which gives me, on my machine

{
  "message": "Bad credentials",
  "documentation_url": "https://developer.github.com/v3"
}

If I remove the dummy login, it works

$> curl -s "https://api.github.com/repos/scala/scala-collection-compat/pulls/268"
{
  "url": "https://api.github.com/repos/scala/scala-collection-compat/pulls/268",
  "id": 344705263,
  "node_id": "MDExOlB1bGxSZXF1ZXN0MzQ0NzA1MjYz",
  "html_url": "https://github.com/scala/scala-collection-compat/pull/268",
  "diff_url": "https://github.com/scala/scala-collection-compat/pull/268.diff",
  "patch_url": "https://github.com/scala/scala-collection-compat/pull/268.patch",
  "issue_url": "https://api.github.com/repos/scala/scala-collection-compat/issues/268",
...

I saw the same in some other repo while ago, don't remember which.. removed the login.

@lrytz
Copy link
Copy Markdown
Member

lrytz commented Nov 26, 2019

hmm, scratch that, i had an old checkout locally; i did remove the dummy login in this repo 78ce868.

@lrytz
Copy link
Copy Markdown
Member

lrytz commented Nov 26, 2019

did a few re-runs, it's green now. not sure what's behind the cla check failure..

@julienrf
Copy link
Copy Markdown
Contributor

julienrf commented Nov 26, 2019

Thank you all for the team work ;)

@julienrf julienrf merged commit ec2702a into scala:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julienrf julienrf julienrf left review comments

+1 more reviewer

@ekrich ekrich ekrich left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xerial @julienrf @lrytz @ekrich