Skip to content

Introduce ExecutionContext.opportunistic for use in apps #9296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lrytz merged 2 commits into from
Nov 13, 2020
Merged

Introduce ExecutionContext.opportunistic for use in apps #9296

lrytz merged 2 commits into from
Nov 13, 2020

Conversation

@viktorklang
Copy link
Contributor

@viktorklang viktorklang commented Oct 29, 2020 •
edited by dwijnand
Loading

Introduces ExecutionContext.opportunistic as a private[scala] instance as an escape-hatch for getting the original 2.13.0 batching global EC

@viktorklang viktorklang added this to the 2.13.4 milestone Oct 29, 2020
@viktorklang viktorklang requested review from dwijnand and lrytz October 29, 2020 21:14
dwijnand
dwijnand approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Viktor!

@viktorklang viktorklang force-pushed the wip-opportunistic-√ branch from 48bd47a to 832b3ef Compare October 29, 2020 22:46
@viktorklang
Copy link
Contributor Author

viktorklang commented Oct 29, 2020

@dwijnand You're most welcome! I added a MIMA exception since that errored out the build. Waiting for build confirmation of success.

lrytz
lrytz reviewed Nov 5, 2020
View reviewed changes
@lrytz lrytz force-pushed the wip-opportunistic-√ branch 3 times, most recently from e433454 to 39edf7e Compare November 9, 2020 12:55
@lrytz
Copy link
Member

lrytz commented Nov 9, 2020

@viktorklang I changed the field to a lazy val and added a second commit with changes to Scaladocs. Let me know what you think.

@lrytz lrytz force-pushed the wip-opportunistic-√ branch from 39edf7e to ffb55ae Compare November 9, 2020 13:01
@viktorklang @lrytz
Introduces ExecutionContext.opportunistic as a private[scala] instanc…
94390f0 
…e as an escape-hatch for getting the original 2.13.0 batching global EC
@lrytz lrytz force-pushed the wip-opportunistic-√ branch from ffb55ae to 48c5232 Compare November 9, 2020 14:34
viktorklang
viktorklang commented Nov 9, 2020
View reviewed changes
viktorklang
viktorklang commented Nov 9, 2020
View reviewed changes
viktorklang
viktorklang commented Nov 9, 2020
View reviewed changes
viktorklang
viktorklang commented Nov 9, 2020
View reviewed changes
@dwijnand dwijnand mentioned this pull request Nov 10, 2020
Closed
72 tasks
@dwijnand dwijnand added the release-notes worth highlighting in next release notes label Nov 10, 2020
@dwijnand dwijnand changed the title Introduces ExecutionContext.opportunistic as a private[scala] instanc… Introduce ExecutionContext.opportunistic for use in apps Nov 10, 2020
@lrytz lrytz force-pushed the wip-opportunistic-√ branch from 48c5232 to 618b63d Compare November 11, 2020 15:13
@lrytz
Copy link
Member

lrytz commented Nov 11, 2020

@viktorklang updated - lgty now?

@viktorklang
Copy link
Contributor Author

viktorklang commented Nov 11, 2020

@lrytz LGTM

@lrytz
Copy link
Member

lrytz commented Nov 12, 2020

There is a remaining issue: private[x] members are skipped by scaladoc unless it runs with -private, which we don't for the library. So noone is going to be able to see these docs that we wrote 😕

Should we move/copy the documentation for opportunistic to global? Other suggestions?

@dwijnand
Copy link
Member

dwijnand commented Nov 12, 2020

I'd say move and point opportunistic's docs to it.

@viktorklang
Copy link
Contributor Author

viktorklang commented Nov 12, 2020

@dwijnand @lrytz Dale's suggestion looks sound to me.

dwijnand
dwijnand reviewed Nov 12, 2020
View reviewed changes
@lrytz lrytz force-pushed the wip-opportunistic-√ branch from 618b63d to 0044904 Compare November 13, 2020 08:16
@lrytz lrytz merged commit 1df410a into scala:2.13.x Nov 13, 2020
@dwijnand dwijnand mentioned this pull request Nov 17, 2020
Merged
hamzaremmal pushed a commit to hamzaremmal/scala3 that referenced this pull request May 2, 2025
@lrytz
Merge pull request scala/scala#9296 from viktorklang/wip-opportunistic-√
60ae208
hamzaremmal pushed a commit to scala/scala3 that referenced this pull request May 7, 2025
@lrytz
Merge pull request scala/scala#9296 from viktorklang/wip-opportunistic-√
7942d15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lrytz lrytz lrytz left review comments

@dwijnand dwijnand dwijnand approved these changes

@som-snytt som-snytt som-snytt left review comments

@sjrd sjrd sjrd left review comments

Assignees

No one assigned

Labels

release-notes worth highlighting in next release notes

Projects

None yet

Milestone

2.13.4

Development

Successfully merging this pull request may close these issues.

5 participants

@viktorklang @lrytz @dwijnand @som-snytt @sjrd