Skip to content

[after #9141] ListMap is reverse oriented, so optimise some APIs #9215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mkeskells wants to merge 1 commit into from
Closed

[after #9141] ListMap is reverse oriented, so optimise some APIs #9215

mkeskells wants to merge 1 commit into from

Conversation

@mkeskells
Copy link
Contributor

@mkeskells mkeskells commented Sep 19, 2020 •
edited
Loading

ListMap.dropRight and take should never allocate
(was ListMap.foldRight should not generate additional garbage (just the tuples), but spun that out in #9218)

@scala-jenkins scala-jenkins added this to the 2.12.13 milestone Sep 19, 2020
@SethTisue SethTisue added library:collections PRs involving changes to the standard collection library performance the need for speed. usually compiler performance, sometimes runtime performance. labels Sep 19, 2020
@mkeskells
Copy link
Contributor Author

mkeskells commented Sep 20, 2020

@lrytz - probably have to wait until #9141 or similar merges

@mkeskells mkeskells mentioned this pull request Sep 20, 2020
Merged
@mkeskells mkeskells force-pushed the 2.12.x_ListMap_Drop_TakeRight branch from 5455514 to 1ae604a Compare October 13, 2020 07:39
@mkeskells mkeskells mentioned this pull request Oct 21, 2020
Closed
@mkeskells mkeskells changed the title ListMap is reverse oriented, so optimise some APIs [after #9141] ListMap is reverse oriented, so optimise some APIs Oct 27, 2020
@mkeskells mkeskells marked this pull request as draft October 27, 2020 07:32
@retronym retronym modified the milestones: 2.12.13, 2.12.14 Nov 23, 2020
@dwijnand
Copy link
Member

dwijnand commented Dec 4, 2020

Going to add this to the list in scala/bug#11804 (comment), and otherwise close this one as we cannot land it without that.

@dwijnand dwijnand closed this Dec 4, 2020
@dwijnand dwijnand mentioned this pull request Dec 4, 2020
Closed
@SethTisue SethTisue removed this from the 2.12.14 milestone Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

library:collections PRs involving changes to the standard collection library performance the need for speed. usually compiler performance, sometimes runtime performance.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mkeskells @dwijnand @retronym @SethTisue @scala-jenkins