Add QualifierTypedAnnotationInfo #9144
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changvvb
force-pushed
the
add-QualifierTypedAnnotationInfo
branch
from
2618be7 to
51710a3
Compare
lrytz
reviewed
Sep 2, 2020
Member
lrytz
left a comment
lrytz
left a comment
There was a problem hiding this comment.
Thank you @changvvb for this patch! I apologize it took so long to get a first review.
I think the existing LazyAnnotationInfo is already a dubious workaround, and the proposed change here pushes that complexity a bit too far.
I'm wondering if we could have a single AnnotationInfo class that has lazy fields, and add support for lazy annotations directly in typer.typedAnnotation. So I started looking at typedAnnotation and, as a first step, did some cleanups / simplifications. I'm testing them here: #9189.
Contributor
Author
|
@lrytz Simplifying AnnotationInfo will be a great breakthrough. |
Member
Member
|
I'd like to get back to it and attempt the AnnotationInfo overhaul I hinted at above, at some point when I have time. |
Member
|
Superseded by #9302 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes scala/bug#11870
Following #9023 (comment), add QualifierTypedAnnotationInfo used to match AnnotationInfo type without fully typechecked