Don't recurse without bound in outerPath (backport) #9119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
dwijnand
approved these changes
Jul 17, 2020
Member
dwijnand
left a comment
dwijnand
left a comment
There was a problem hiding this comment.
LGTM. Mind squashing or rebasing?
ivanopagano
force-pushed
the
topic/t10035-2.12-backport
branch
from
8da5705 to
1e567b4
Compare
Contributor
Author
I've currently rebased my fork (which was originally stale) on the branch from the scala origin. And rebased the change on top of that. I might be unfamiliar with how to properly reset the fork in sync with scala/scala original branch, so that no spurious commits show up anymore. Edit: working to fix that |
* copy the bugfix for scala/bug#10035 to the 2.12.x branch, as-is
ivanopagano
force-pushed
the
topic/t10035-2.12-backport
branch
from
1e567b4 to
e5175d1
Compare
Contributor
Author
|
@dwijnand should be better now |
lrytz
approved these changes
Jul 20, 2020
SethTisue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy-paste solution from the 2.13.x branch of @milessabin philosophical PR #7178
It's an attempt at back-porting the solution to the 2.12.x branch.
Fixes scala/bug#10035
Honestly I have no idea why this should work, but the new test scenario passes on this branch too, so I'm making the attempt to merge it.
I would expect someone better positioned to evaluate potential errors in the solution.