Skip to content

[nomerge] small cleanups #9083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lrytz merged 2 commits into from
Jun 25, 2020
Merged

[nomerge] small cleanups #9083

lrytz merged 2 commits into from
Jun 25, 2020

Conversation

@lrytz
Copy link
Member

@lrytz lrytz commented Jun 24, 2020

No description provided.

@lrytz lrytz requested a review from retronym June 24, 2020 10:00
@scala-jenkins scala-jenkins added this to the 2.12.13 milestone Jun 24, 2020
lrytz
lrytz commented Jun 24, 2020
View reviewed changes
src/library/scala/collection/immutable/HashMap.scala
}
}
that.asInstanceOf[scala.Traversable[(A,B)]] foreach adder
that.asInstanceOf[GenTraversableOnce[(A,B)]] foreach adder
Copy link
Member Author

@lrytz lrytz Jun 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure here, but it seemed a bit strange for this code to be different than ++ above

@lrytz
Copy link
Member Author

lrytz commented Jun 24, 2020

@retronym I also don't really grok what the new castToThat methods are good for, maybe you can add a comment?

@retronym
Copy link
Member

retronym commented Jun 25, 2020

@retronym I also don't really grok what the new castToThat methods are good for, maybe you can add a comment?

Done. They exist to ensure we only cast suitable values to That. One of the bugs I fixed was casting a totally unrelalated type to HashMap[A, B] in a code path that wasn't tested, so I was looking for ways to be a bit safer with the casts.

@lrytz lrytz merged commit cbe6ade into scala:2.12.x Jun 25, 2020
@SethTisue SethTisue modified the milestones: 2.12.13, 2.12.12 Jun 25, 2020
hamzaremmal pushed a commit to hamzaremmal/scala3 that referenced this pull request May 2, 2025
@lrytz
Merge pull request scala/scala#9083 from lrytz/smallCleanups
e5f4360 
[nomerge] small cleanups
hamzaremmal pushed a commit to scala/scala3 that referenced this pull request May 7, 2025
@lrytz
Merge pull request scala/scala#9083 from lrytz/smallCleanups
80aa1cd 
[nomerge] small cleanups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@retronym retronym retronym approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.12.12

Development

Successfully merging this pull request may close these issues.

4 participants

@lrytz @retronym @SethTisue @scala-jenkins