Skip to content

Fix @nowarn to use correct semantics for & #9032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SethTisue merged 1 commit into from
Jun 3, 2020
Merged

Fix @nowarn to use correct semantics for & #9032

SethTisue merged 1 commit into from
Jun 3, 2020

Conversation

@som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Jun 3, 2020

@scala-jenkins scala-jenkins added this to the 2.13.4 milestone Jun 3, 2020
@som-snytt som-snytt modified the milestones: 2.13.4, 2.13.3 Jun 3, 2020
@som-snytt som-snytt requested a review from lrytz June 3, 2020 04:44
dwijnand
dwijnand approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tyvm, Som!!

@som-snytt
Copy link
Contributor Author

som-snytt commented Jun 3, 2020

Every time I undertake to understand -Wconf better, it's a little less scary, a little bit friendlier, and I realize I will miss it under doti.

@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Jun 3, 2020
@SethTisue SethTisue merged commit 92809e8 into scala:2.13.x Jun 3, 2020
@som-snytt som-snytt deleted the issue/12026 branch June 3, 2020 16:10
@SethTisue SethTisue changed the title All filters must match for nowarn Fix @nowarn to use correct semantics for & Jun 23, 2020
@dwijnand dwijnand mentioned this pull request Oct 16, 2020
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwijnand dwijnand dwijnand approved these changes

@lrytz lrytz Awaiting requested review from lrytz

Assignees

No one assigned

Labels

release-notes worth highlighting in next release notes

Projects

None yet

Milestone

2.13.3

Development

Successfully merging this pull request may close these issues.

@nowarn seems to use "OR" semantics for &

4 participants

@som-snytt @dwijnand @SethTisue @scala-jenkins