Skip to content

Map ++ without CBF should use the same optimised path as ++ with CBF #8986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lrytz merged 1 commit into from
Aug 14, 2020
Merged

Map ++ without CBF should use the same optimised path as ++ with CBF #8986

lrytz merged 1 commit into from
Aug 14, 2020

Conversation

@mkeskells
Copy link
Contributor

@mkeskells mkeskells commented May 14, 2020

also optimise for small map addition

@mkeskells mkeskells requested a review from retronym May 14, 2020 22:33
@scala-jenkins scala-jenkins added this to the 2.12.12 milestone May 14, 2020
@SethTisue SethTisue added library:collections PRs involving changes to the standard collection library performance the need for speed. usually compiler performance, sometimes runtime performance. labels May 16, 2020
@retronym retronym modified the milestones: 2.12.12, 2.12.13 Jul 1, 2020
@mkeskells mkeskells requested a review from lrytz August 2, 2020 15:31
lrytz
lrytz reviewed Aug 13, 2020
View reviewed changes
lrytz
lrytz reviewed Aug 14, 2020
View reviewed changes
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after squashing the changes.

@mkeskells
Copy link
Contributor Author

mkeskells commented Aug 14, 2020 •
edited
Loading

LGTM, after squashing the changes.

squashed and added
case m: AnyRef if m eq EmptyMap if the 5 places suggested

@lrytz lrytz merged commit 5997a61 into scala:2.12.x Aug 14, 2020
@dwijnand dwijnand mentioned this pull request Sep 17, 2020
Closed
hamzaremmal pushed a commit to hamzaremmal/scala3 that referenced this pull request May 2, 2025
@lrytz
Merge pull request scala/scala#8986 from mkeskells/2.12.x_smallMap++
bc79733 
Map ++ without CBF should use the same optimised path as ++ with CBF
hamzaremmal pushed a commit to scala/scala3 that referenced this pull request May 7, 2025
@lrytz
Merge pull request scala/scala#8986 from mkeskells/2.12.x_smallMap++
6b21347 
Map ++ without CBF should use the same optimised path as ++ with CBF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lrytz lrytz lrytz approved these changes

@retronym retronym Awaiting requested review from retronym

+1 more reviewer

@diesalbla diesalbla diesalbla approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

library:collections PRs involving changes to the standard collection library performance the need for speed. usually compiler performance, sometimes runtime performance.

Projects

None yet

Milestone

2.12.13

Development

Successfully merging this pull request may close these issues.

6 participants

@mkeskells @lrytz @diesalbla @retronym @SethTisue @scala-jenkins