Avoid Tuple Allocation in groupBy #8935
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retronym
force-pushed
the
topic/group-by-foreach-entry
branch
3 times, most recently
from
b3f1674 to
742bbb5
Compare
retronym
changed the title
retronym
force-pushed
the
topic/group-by-foreach-entry
branch
from
742bbb5 to
e831e46
Compare
diesalbla
added
the
library:collections
Contributor
|
is this still live? |
Member
Author
|
This still has some value separate to #8948, but it a an bigger/uglier patch and might not make meet the cost/benefit calculation. I thought I'd leave it as a draft PR for now. |
mkeskells
reviewed
May 5, 2020
| */ | ||
| package scala.collection.mutable | ||
|
|
||
| private[collection] trait EfficientMapBuilder[K, V] extends ((K, V, (K, V)) => Unit) { |
Contributor
There was a problem hiding this comment.
:-)
This is probably useful in several other places
e.g. for the caller to override def ++=(xs: TraversableOnce[(A, B)]): in HashMapBuilder, conversion from Map4, MapBuilder ( when it switches to use a HashMapBuilder), and for anything else that is a HasForEachEntry
Member
|
Closing for inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterate the entry set of the mutable map without tuples and avoid the need for tuples for each entry when building the immutable Map result.