Skip to content

Conversation

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Apr 14, 2020

high ratio of hours spent debugging to size of resulting fix, here

fixes scala/scala-dev#706

@scala-jenkins scala-jenkins added this to the 2.13.3 milestone Apr 14, 2020
@SethTisue SethTisue requested a review from som-snytt April 14, 2020 04:41
@SethTisue SethTisue modified the milestones: 2.13.3, 2.13.2 Apr 14, 2020
@SethTisue SethTisue added the tool:REPL Changes to the Scala REPL shell label Apr 14, 2020
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lrytz lrytz merged commit a789d81 into scala:2.13.x Apr 14, 2020
@SethTisue SethTisue deleted the jline-tokenizer-errors branch April 14, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool:REPL Changes to the Scala REPL shell

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JLine 3: errors during tokenization are mishandled (in multiple ways)

4 participants