Fix warning site for unused warnings #8852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though these warnings are emitted in the typer phase, the actual invocation is done at the end of type checking in the root context. So we should not use the `context.warning` method, as it injects `context.owner` as the warning site, which is always the root symbol.
som-snytt
approved these changes
Apr 3, 2020
Contributor
som-snytt
left a comment
som-snytt
left a comment
There was a problem hiding this comment.
I haven't completed the Wconf Coursera yet.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though these warnings are emitted in the typer phase, the actual
invocation is done at the end of type checking in the root context.
So we should not use the
context.warningmethod, as it injectscontext.owneras the warning site, which is always the root symbol.