Move files of utilities in the testkit package to the testkit project#8378
Merged
lrytz merged 1 commit intoscala:2.13.xfrom Aug 28, 2019
Merged
Move files of utilities in the testkit package to the testkit project#8378lrytz merged 1 commit intoscala:2.13.xfrom
lrytz merged 1 commit intoscala:2.13.xfrom
Conversation
SethTisue
reviewed
Aug 27, 2019
Member
|
previous history is in #7817 + #7847 there is a test failure, reproducible locally: I think it's caused by this change - .dependsOn(library)
+ .dependsOn(compiler)because the test picks up the compiler |
SethTisue
approved these changes
Aug 27, 2019
Member
SethTisue
left a comment
SethTisue
left a comment
There was a problem hiding this comment.
LGTM for merge once test failure is addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.