Un-deprecate option2Iterable implicit conversion
#8106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The selection of methods available on `Option` is not very consistent. For example, there is `.toList`, but not `.to` or any of the other standard conversion methods like `.toVector`, `.toSet`, etc. There are likely other methods that are commonly used today, but only available through `option2Iterable` (e.g., `mkString`). It's too late for 2.13 to go over Option's API. Keeping `option2Iterable` covers up some of the shortcomings, and it's the same as in 2.12, therefore backwards compatible.
diesalbla
added
the
library:collections
Contributor
|
What's the worst that can happen in pretending Option is a full collection? Is avoiding that "worst" worth annoying users who just want to do a |
Contributor
|
(Yes, I know I initially suggested the deprecation as a compromise -- in a perfect world, I would prefer keeping it, but I no longer think it's compelling enough.) |
Member
Author
|
I would still deprecate the conversion at some point, but after making sure that commonly used methods exist on |
SethTisue
changed the title
option2Iterableoption2Iterable implicit conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The selection of methods available on
Optionis not very consistent.For example, there is
.toList, but not.toor any of the otherstandard conversion methods like
.toVector,.toSet, etc. There arelikely other methods that are commonly used today, but only available
through
option2Iterable(e.g.,mkString).It's too late for 2.13 to go over Option's API. Keeping
option2Iterablecovers up some of the shortcomings, and it's the sameas in 2.12, therefore backwards compatible.