Skip to content

Conversation

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Mar 11, 2019

sequel to #7817

this is needed in order to avoid using "compile->test" which
we can't replicate in the IntelliJ project (we don't think)

it's better this way anyway, the partest->junit dependency was
unnecessarily thick, this replaces it with a thin dependency. I had
strongly considered doing this anyway as part of #7817

@scala-jenkins scala-jenkins added this to the 2.13.1 milestone Mar 11, 2019
@SethTisue
Copy link
Member Author

SethTisue commented Mar 11, 2019

before merge, we need to add in (and test) the necessary IntelliJ setup changes

@SethTisue
Copy link
Member Author

SethTisue commented Mar 11, 2019

so far my approach is "put the minimum amount of code in testing", to get a first working version green quickly

but it would probably be better if I went on and moved as much code as possible out of junit. basically anything that isn't actually a test. since any test utility code is potentially useful in partests too

@dwijnand
Copy link
Member

👨‍🎨 You could follow Lightbend's (organic) naming convention and call it "testkit" 🙂

@SethTisue
Copy link
Member Author

SethTisue commented Mar 11, 2019

moved as much code as possible out of junit

hmm, some of the support code seems pretty specific to the JUnit-based tests. so I'm not going to move all of it, just the ones that seem plausibly useful elsewhere. (anyway, not a high-stakes decision, we can always shuffle this stuff around further.)

@SethTisue
Copy link
Member Author

You could follow Lightbend's (organic) naming convention and call it "testkit"

hmm. the package name is scala.tools.testing. I do like testkit, but we'd want to rename the package too, I think.

@hrhino
Copy link
Contributor

hrhino commented Mar 11, 2019

a tistkit, a testkit...

@SethTisue SethTisue force-pushed the split-junit-sources branch from 273223e to 794ef93 Compare March 11, 2019 19:22
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squash and go

SethTisue and others added 2 commits March 11, 2019 16:57
sequel to scala#7817

this is needed in order to avoid using "compile->test" which
we can't replicate in the IntelliJ project (we don't think)

it's better this way anyway, the old partest->junit dependency was
unnecessarily thick, this replaces it with a thin dependency. I had
strongly considered doing this anyway as part of scala#7817
@SethTisue SethTisue force-pushed the split-junit-sources branch from cbb4eb4 to 63d2580 Compare March 11, 2019 20:57
@SethTisue
Copy link
Member Author

SethTisue commented Mar 11, 2019

squashed — yes, let's merge on the fast track, once CI likes it, to get IntelliJ working again. we can always refine further later.

@SethTisue
Copy link
Member Author

SethTisue commented Mar 11, 2019

@som-snytt you might want to take a quick look and make sure I didn't misunderstand assert8

a tistkit, that's what our kiwi contributors call it

@som-snytt
Copy link
Contributor

@hrhino tsk, tsk.

@som-snytt
Copy link
Contributor

I recorded my vote against the package name testkit. A testkit tests for conformances.

@SethTisue 834e29f#commitcomment-4094652

@SethTisue
Copy link
Member Author

testSupport is an okay sbt project name, but then we would still need a package name. test-support? meh

I don't understand what you mean by "conformances".

to me the main problem with testing, as opposed to e.g. testkit, is that's a hard to talk about out loud without rampant ambiguity.

@SethTisue
Copy link
Member Author

(do you dislike the name testkit in Akka and a number of other Scala-based projects too... or, you think it's fine there but just not right here?)

SethTisue referenced this pull request Mar 11, 2019
This is much easier to use than built-in JUnit method-level checks.
@som-snytt
Copy link
Contributor

som-snytt commented Mar 11, 2019

I don't remember adding assert8 there, but it seems it could now be accessed from:

test/files/jvm/javaReflection/Test.scala

Edit: I have a feeling retronym suggested assert8 and other fixes at that time.

@som-snytt
Copy link
Contributor

I think they use "testkit" as a rig for running a suite. Isn't it a set of tests for a feature or framework? as opposed to a general utility or framework for testing.

How about "scala enhanced test housing" or seth.

@SethTisue
Copy link
Member Author

SethTisue commented Mar 11, 2019

Akka's testkit is definitely utilities-and-frameworks-for-writing-tests-with, not a particular suite. That's my understanding of the term.

Cats, same.

Let's save the name seth for something much more grand. (In StarLogo/NetLogo it used to mean set heading, until I took it out.)

@som-snytt
Copy link
Contributor

@SethTisue SethTisue merged commit 3e59216 into scala:2.13.x Mar 11, 2019
@SethTisue SethTisue deleted the split-junit-sources branch March 11, 2019 22:27
@som-snytt
Copy link
Contributor

Or "test kitchen", the "kitchen" for short.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants