-
Notifications
You must be signed in to change notification settings - Fork 3.1k
split out shared testing code into new subproject #7847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
before merge, we need to add in (and test) the necessary IntelliJ setup changes |
|
so far my approach is "put the minimum amount of code in but it would probably be better if I went on and moved as much code as possible out of |
|
👨🎨 You could follow Lightbend's (organic) naming convention and call it "testkit" 🙂 |
hmm, some of the support code seems pretty specific to the JUnit-based tests. so I'm not going to move all of it, just the ones that seem plausibly useful elsewhere. (anyway, not a high-stakes decision, we can always shuffle this stuff around further.) |
hmm. the package name is |
|
a tistkit, a testkit... |
273223e to
794ef93
Compare
lrytz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
squash and go
sequel to scala#7817 this is needed in order to avoid using "compile->test" which we can't replicate in the IntelliJ project (we don't think) it's better this way anyway, the old partest->junit dependency was unnecessarily thick, this replaces it with a thin dependency. I had strongly considered doing this anyway as part of scala#7817
cbb4eb4 to
63d2580
Compare
|
squashed — yes, let's merge on the fast track, once CI likes it, to get IntelliJ working again. we can always refine further later. |
|
@som-snytt you might want to take a quick look and make sure I didn't misunderstand a tistkit, that's what our kiwi contributors call it |
|
@hrhino tsk, tsk. |
|
I recorded my vote against the package name |
|
I don't understand what you mean by "conformances". to me the main problem with |
|
(do you dislike the name |
This is much easier to use than built-in JUnit method-level checks.
|
I don't remember adding test/files/jvm/javaReflection/Test.scala Edit: I have a feeling retronym suggested assert8 and other fixes at that time. |
|
I think they use "testkit" as a rig for running a suite. Isn't it a set of tests for a feature or framework? as opposed to a general utility or framework for testing. How about "scala enhanced test housing" or |
|
Akka's testkit is definitely utilities-and-frameworks-for-writing-tests-with, not a particular suite. That's my understanding of the term. Cats, same. Let's save the name |
|
Or "test kitchen", the "kitchen" for short. |
sequel to #7817
this is needed in order to avoid using "compile->test" which
we can't replicate in the IntelliJ project (we don't think)
it's better this way anyway, the partest->junit dependency was
unnecessarily thick, this replaces it with a thin dependency. I had
strongly considered doing this anyway as part of #7817