Avoid CCE with no message #7819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test relies on testing the message of a ClassCastException, but if the method that throws it is JIT-compiled, the message is null. This was observed when an unrelated test was added to the in-process suite which over-exercised the method and caused it to be compiled. Adding `.javaopts` causes the test to run out-of- process, and the supplied option also turns off compilation for the method in question.
Contributor
Author
|
On second thought, it would be nicer not to rely on |
Member
|
😍 |
Member
|
giving this a workout now over at #7817 |
Member
|
seriously, I'm so glad you figured this out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test relies on testing the message of a
ClassCastException, but if the method that throws
it is JIT-compiled, the message is null. This was
observed when an unrelated test was added to the
in-process suite which over-exercised the method
and caused it to be compiled.
Adding
.javaoptscauses the test to run out-of-process, and the supplied option also turns off
compilation for the method in question.