Unit companion is compileTimeOnly #7698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM for merge after squash/rebase |
Contributor
Author
|
Refreshing my memory: previously, "flipping the switch" was a separate commit because it required a fresh starr. (A STARR is Born!) The innovation here is that the "group" mechanism only requires a type, so additional groups were added to cover the compiler and library. |
Annotations get a dispensation for the ref check. The `Group` mechanism for specialized is moved to the type level. Unleash Unit restriction Add some convenience groups to Specializable and avoid usages of Unit companion in library so that Unit companion can be compileTimeOnly without compiler assistance. Regenerate AnyVals
som-snytt
force-pushed
the
issue/Unit-disallowed-2.13
branch
from
7b16b0a to
3383edd
Compare
Member
|
thanks, Som, for your patience, as always. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #7567