Fix for numeric underflow with BigDecimal in NumericRange. #7670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fixes scala/bug#11152, alternative to #7516 that doesn't reintroduce old bugs |
NthPortal
reviewed
Jan 22, 2019
szeiger
reviewed
Jan 23, 2019
51 tasks
Contributor
|
Sounds like this is ready to merge? |
Contributor
Author
|
@adriaanm - I still need to fix the test to test something. |
Contributor
|
Ping @Ichoran |
Contributor
Author
|
Oops. I'll get to it tonight or tomorrow. |
Contributor
Author
|
...or not. Definitely during the weekend; maybe Friday evening, but since I'm in California I don't expect there will be any practical difference. |
Doesn't address the difficult issue of what the "natural" behavior is for BigDecimal. Instead, it just takes the precision it's given and throws an exception if the step size cannot be represented without loss. Tests for appropriate behavior are included.
Contributor
Author
|
@adriaanm - All ready now, assuming the tests pass. (They pass locally.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't address the difficult issue of what the "natural" behavior is for
BigDecimal. Instead, it just takes the precision it's given and throws
an exception if the step size cannot be represented without loss.