Skip to content

Make PartialFunction#andThen properly handle upcast PFs #7552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lrytz merged 1 commit into from
Dec 19, 2018
Merged

Make PartialFunction#andThen properly handle upcast PFs #7552

lrytz merged 1 commit into from
Dec 19, 2018

Conversation

@dwijnand
Copy link
Member

@dwijnand dwijnand commented Dec 19, 2018

No description provided.

@scala-jenkins scala-jenkins added this to the 2.13.0-RC1 milestone Dec 19, 2018
@dwijnand dwijnand requested review from NthPortal and lrytz December 19, 2018 07:23
@dwijnand dwijnand mentioned this pull request Dec 19, 2018
Merged
@danslapman
Copy link
Contributor

danslapman commented Dec 19, 2018

LGTM

lrytz
lrytz approved these changes Dec 19, 2018
View reviewed changes
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@lrytz lrytz merged commit c7838e1 into scala:2.13.x Dec 19, 2018
@dwijnand dwijnand deleted the PF-andThen-upcast-PF branch December 19, 2018 09:13
@dwijnand
Copy link
Member Author

dwijnand commented Dec 19, 2018

That turnaround time! ❤️

@SethTisue SethTisue mentioned this pull request Jan 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lrytz lrytz lrytz approved these changes

@NthPortal NthPortal Awaiting requested review from NthPortal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.13.0-RC1

Development

Successfully merging this pull request may close these issues.

4 participants

@dwijnand @danslapman @lrytz @scala-jenkins