Skip to content

Conversation

@smarter
Copy link
Member

@smarter smarter commented Dec 15, 2018

@scala-jenkins scala-jenkins added this to the 2.13.0-RC1 milestone Dec 15, 2018
@smarter smarter force-pushed the deprecate-unicode-arrows branch 2 times, most recently from fd7d343 to 9dd13d8 Compare December 15, 2018 22:38
@som-snytt
Copy link
Contributor

More like 💘 an arrow through the heart.

@He-Pin
Copy link
Contributor

He-Pin commented Dec 17, 2018

I could only rely on the formatter to help me input these arrows.

@som-snytt
Copy link
Contributor

Will we ever get the arrows back as operator characters? Page one of the spec should clarify.

@SethTisue
Copy link
Member

I'm in favor, because of the precedence considerations (scala/bug#11210). also more generally it just seems better to me to not go the Unicode-symbol path at all, rather than maybe have it piecemeal here and there for a few things

any other @scala/committers opinions?

Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olafurpg
Copy link
Contributor

I agree scala/bug#11210 is a good reason to deprecate unicode arrows but want to note that unicode arrows are widely used (it was a heavily requested Scalafmt feature). Scalafmt supports rewriting unicode to ascii and vice-versa. If unicode arrows are deprecated in the language we will likely remove the option to go to unicode and by default rewrite unicode into ascii.

@adriaanm
Copy link
Contributor

adriaanm commented Jan 10, 2019 via email

@dwijnand
Copy link
Member

The Akka Team's fine with losing them. 🙂

@hrhino
Copy link
Contributor

hrhino commented Jan 10, 2019

I've always thought they were kinda cute, and generally harmless. The precedence bug puts the lie to harmlessness, though, so I'm okay with dropping them and relying on my fancy ligature font.

@NthPortal
Copy link
Contributor

I'm in favour of removing them

@mdedetrich
Copy link
Contributor

Also in favor of removing them, use font-ligatures (which are now very widely supported in basically every editor) if you want these symbols

@smarter smarter force-pushed the deprecate-unicode-arrows branch from 9dd13d8 to 88546d7 Compare January 18, 2019 09:29
@smarter
Copy link
Member Author

smarter commented Jan 18, 2019

Rebasing and merging since there appears to be consensus.

@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Jan 18, 2019
@SethTisue
Copy link
Member

Will we ever get the arrows back as operator characters? Page one of the spec should clarify

I think that could happen at the time of actual removal

@smarter smarter merged commit 9e26448 into scala:2.13.x Jan 18, 2019
melezov added a commit to melezov/Kamon that referenced this pull request Jul 28, 2019
ivantopo pushed a commit to kamon-io/Kamon that referenced this pull request Aug 9, 2019
* Remove Unicode arrows (deprecated in Scala 2.13)

Reference:
scala/scala#7540

* Linter: Fix unused config parameter

SuperSafe: Remove usage of .equals
Scalafix: remove unused imports & private hex function

There is no need to guard against LHS null in Scala equality and isInstanceOf

* Remove some hidden typos

* Bump legacy Scala to 2.12.8

* Enable TLS security in README, bump shields to Scala 2.13
derrickoswald pushed a commit to derrickoswald/CIMSpark that referenced this pull request Aug 23, 2019
- final case classes
- no return() statements
- use ASCII arrows instead of unicode arrows `⇒`, `←` and `→`
- avoid '+' for string concatenation

ref:
Scala best practices https://nrinaudo.github.io/talk-scala-best-practices/#72
Issue #14 #14
ASCII arrows scala/scala#7540
@retronym
Copy link
Member

IntelliJ IDEA now ships with JetBrains Mono, a programming font with great ligature support for constructs used in Scala code. It will be the default font in the upcoming IDE release. https://www.jetbrains.com/lp/mono/

novakov-alexey-zz pushed a commit to novakov-alexey-zz/kubernetes-client-one that referenced this pull request Apr 13, 2020
novakov-alexey-zz pushed a commit to novakov-alexey-zz/kubernetes-client-one that referenced this pull request Apr 13, 2020
novakov-alexey-zz pushed a commit to novakov-alexey-zz/kubernetes-client-one that referenced this pull request Apr 13, 2020
Kazark pushed a commit to Kazark/spacemacs that referenced this pull request May 28, 2020
As of Scala 2.13, Unicode arrows are deprecated:

* scala/scala#7540
* scala/scala-dev#585
* scala/bug#11210

Using one will give a deprecation warnings like so:

> The unicode arrow `⇒` is deprecated, use `=>` instead. If you still wish to
> display it as one character, consider using a font with programming ligatures
> such as Fira Code.

As such the Scala layer's version slick capability to replace ASCII arrows with
Unicode ones is no longer useful, and I have removed it.

Based on my tests it doesn't seem that there is a need for a more graceful way
to deprecate this: i.e. nothing fails if there is extra junk in `:variables`.
Kazark pushed a commit to Kazark/spacemacs that referenced this pull request May 28, 2020
As of Scala 2.13, Unicode arrows are deprecated:

* scala/scala#7540
* scala/scala-dev#585
* scala/bug#11210

Using one will give a deprecation warnings like so:

> The unicode arrow `⇒` is deprecated, use `=>` instead. If you still wish to
> display it as one character, consider using a font with programming ligatures
> such as Fira Code.

As such the Scala layer's version slick capability to replace ASCII arrows with
Unicode ones is no longer useful, and I have removed it.

Based on my tests it doesn't seem that there is a need for a more graceful way
to deprecate this: i.e. nothing fails if there is extra junk in `:variables`.
duianto pushed a commit to syl20bnr/spacemacs that referenced this pull request Jun 7, 2020
As of Scala 2.13, Unicode arrows are deprecated:

* scala/scala#7540
* scala/scala-dev#585
* scala/bug#11210

Using one will give a deprecation warnings like so:

> The unicode arrow `⇒` is deprecated, use `=>` instead. If you still wish to
> display it as one character, consider using a font with programming ligatures
> such as Fira Code.

As such the Scala layer's version slick capability to replace ASCII arrows with
Unicode ones is no longer useful, and I have removed it.

Based on my tests it doesn't seem that there is a need for a more graceful way
to deprecate this: i.e. nothing fails if there is extra junk in `:variables`.
aam-at pushed a commit to aam-at/spacemacs that referenced this pull request Mar 23, 2021
As of Scala 2.13, Unicode arrows are deprecated:

* scala/scala#7540
* scala/scala-dev#585
* scala/bug#11210

Using one will give a deprecation warnings like so:

> The unicode arrow `⇒` is deprecated, use `=>` instead. If you still wish to
> display it as one character, consider using a font with programming ligatures
> such as Fira Code.

As such the Scala layer's version slick capability to replace ASCII arrows with
Unicode ones is no longer useful, and I have removed it.

Based on my tests it doesn't seem that there is a need for a more graceful way
to deprecate this: i.e. nothing fails if there is extra junk in `:variables`.
rtyley added a commit to rtyley/dotty that referenced this pull request Jul 31, 2021
Unicode arrows are deprecated in Scala 2.13, thanks to
scala/scala#7540 merged in January 2019. For
consistency, unless there's been a conscious decision to _un_deprecate
them, we should continue that on into Scala 3.
rtyley added a commit to rtyley/dotty that referenced this pull request Aug 1, 2021
Unicode arrows are deprecated in Scala 2.13, thanks to
scala/scala#7540 merged in January 2019. For
consistency, unless there's been a conscious decision to _un_deprecate
them, we should continue that on into Scala 3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes worth highlighting in next release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate spec-defined and standard-library-defined unicode operators (⇒, ←, →) Priorities of arrow operators variants