Skip to content

Conversation

@dwijnand
Copy link
Member

@dwijnand dwijnand commented Dec 14, 2018

@scala-jenkins scala-jenkins added this to the 2.13.0-RC1 milestone Dec 14, 2018
@dwijnand dwijnand mentioned this pull request Dec 15, 2018
3 tasks
@dwijnand dwijnand force-pushed the unused branch 2 times, most recently from 0e5d827 to 4c8db60 Compare December 17, 2018 10:28
@dwijnand dwijnand changed the title Introduce @unused Introduce an unused annotation Dec 17, 2018
@dwijnand dwijnand added the release-notes worth highlighting in next release notes label Dec 17, 2018
@dwijnand

This comment has been minimized.

@dwijnand

This comment has been minimized.

@dwijnand dwijnand closed this Dec 29, 2018
@dwijnand dwijnand reopened this Dec 29, 2018
@SethTisue
Copy link
Member

  • This extends @deprecated because the compiler's unused linting ignores items annotated with
  • @deprecated.

@som-snytt would it be difficult for the unused-detection code to recognize @unused directly? otherwise it seems like piling hack upon hack. annotations extending each other seems weird to me, and hijacking @deprecated in this context was a hack in the first place

@som-snytt
Copy link
Contributor

Although this solution has a certain elegance to it, superseded by #7623 which instead of piling hack upon hack, just shoves it off to one side and maybe spreads it around a little to make sure the garden is evenly fertilized.

@som-snytt som-snytt closed this Jan 9, 2019
@dwijnand dwijnand deleted the unused branch January 9, 2019 21:31
@SethTisue SethTisue removed the release-notes worth highlighting in next release notes label Jan 10, 2019
@SethTisue SethTisue removed this from the 2.13.0-RC1 milestone Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants