Try to drop symbol literals #7499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
refs:#7395 |
ashawley
force-pushed
the
2.13-drop-symlit
branch
from
a9d0fb6 to
fff2077
Compare
ashawley
force-pushed
the
2.13-drop-symlit
branch
2 times, most recently
from
95f2c61 to
964b203
Compare
ashawley
force-pushed
the
2.13-drop-symlit
branch
from
964b203 to
2d495c3
Compare
ashawley
commented
Dec 6, 2018
| val q"${s: scala.Symbol}" = q"'foo" | ||
| assert(s.isInstanceOf[scala.Symbol] && s == 'foo) | ||
| val q"${s: scala.Symbol}" = q"""sym"foo"""" | ||
| assert(s.isInstanceOf[scala.Symbol] && s == sym"foo") |
Member
Author
There was a problem hiding this comment.
There's no way to make this reflection test of symbols to work:
! unliftable.unlift scala.symbol: Exception raised on property evaluation.
> Exception: scala.MatchError: StringContext("foo").sym() (of class scala.reflect.internal.Trees$Apply)
scala.reflect.quasiquotes.UnliftableProps$.$anonfun$new$26(UnliftableProps.scala:76)
Probably not a big loss?
Member
Author
There was a problem hiding this comment.
Actually, it looks like this is how utest implements symbol-based test names:
Fortunately, utest already supports a string-based alternative.
Member
|
I'd say this experiment went well. Should this PR saty open? |
Member
Author
|
I was going to continue the experiment by having it run in the community build, scala/community-build#824, but I was waiting for Seth to get back from vacation. However, I predict this will need to be backported to a 2.12 branch to get any real feedback from community build, though, since the 2.13 community build isn't very far along, yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a demonstration of dropping symbol literals to answer at least two questions:
For (2), this experiment is based upon the new
symsyntax feature branch in the pull request #7495.Proposal to deprecate symbol literals is scala/scala-dev#459.