Skip to content

Display parsing warnings in REPL #7467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adriaanm merged 1 commit into from
Nov 27, 2018
Merged

Display parsing warnings in REPL #7467

adriaanm merged 1 commit into from
Nov 27, 2018

Conversation

@eed3si9n
Copy link
Member

@eed3si9n eed3si9n commented Nov 27, 2018

In #6325 (comment) @SethTisue reported that procedure syntax deprecation warnings are not displayed on REPL.

% /usr/local/scala/scala-2.13.0-M5/bin/scala -deprecation        
Welcome to Scala 2.13.0-M5 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_192).
Type in expressions for evaluation. Or try :help.

scala> def foo() { }
foo: ()Unit

This is because warnings were filtered out by withoutWarnings in #5647 to fix scala/bug#10130.
On 2.13.x, it seems to work ok without the withoutWarnings filter during parse.

@eed3si9n
Display parsing warnings in REPL
30521b5 
In scala#6325 Seth reported that procedure syntax
deprecation warnings are not displayed on REPL.
This is because warnings were filtered out by `withoutWarnings` in scala#5647 to fix scala/bug#10130.
On 2.13.x, it seems to work ok without the `withoutWarnings` filter during parse.
@scala-jenkins scala-jenkins added this to the 2.13.0-RC1 milestone Nov 27, 2018
som-snytt
som-snytt approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@som-snytt som-snytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And the carets line up right! Note the parse trees are now spliced into the template, since the rebirth of REPL as Adriaanite.

@adriaanm
Copy link
Contributor

adriaanm commented Nov 27, 2018

Thanks for the fix & review!

@adriaanm adriaanm merged commit 5e47362 into scala:2.13.x Nov 27, 2018
@som-snytt som-snytt mentioned this pull request Nov 27, 2018
Closed
@eed3si9n eed3si9n deleted the wip/repl-warnings branch November 27, 2018 20:40
@som-snytt
Copy link
Contributor

som-snytt commented Feb 14, 2019

Why did I have to joke about the caret lining up? The position is actually a bit weird.

scala> trait T { def f() }
                        ^
       warning: procedure syntax is deprecated: instead, add `: Unit` to explicitly declare `f`'s return type
defined trait T

@som-snytt som-snytt mentioned this pull request Feb 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@som-snytt som-snytt som-snytt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.13.0-RC1

Development

Successfully merging this pull request may close these issues.

Multiple syntax warnings in REPL

4 participants

@eed3si9n @adriaanm @som-snytt @scala-jenkins