Increase suppression granularity in Using.resource #7457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NthPortal
commented
Nov 22, 2018
He-Pin
reviewed
Nov 22, 2018
| case _: InterruptedException | _: ThreadDeath => 2 | ||
| case _: ControlThrowable => 0 | ||
| case e if !NonFatal(e) => 1 // in case this method gets out of sync with NonFatal | ||
| case _ => -1 |
Contributor
There was a problem hiding this comment.
Is there any chance to make this 4,3,2,1,0,-1 to be named constants?
Contributor
Author
There was a problem hiding this comment.
does that improve clarity? They're only used here, and I would think it's clearer when you can see their values (since they're not quite in sorted order)
Contributor
Author
There was a problem hiding this comment.
(because ControlThrowable sorts below other fatals, it needs to be matched before NonFatal, or they'll end up with the same score/rank)
NthPortal
force-pushed
the
topic/using-suppression/PR
branch
from
58fc438 to
6129108
Compare
NthPortal
commented
Nov 23, 2018
NthPortal
commented
Nov 23, 2018
| case _: InterruptedException | _: ThreadDeath => 2 | ||
| case _: ControlThrowable => 0 | ||
| case e if !NonFatal(e) => 1 // in case this method gets out of sync with NonFatal | ||
| case _ => -1 |
Contributor
Author
There was a problem hiding this comment.
I am open to discussing whether this is in fact the best hierarchy
Contributor
Author
|
review @Ichoran |
NthPortal
force-pushed
the
topic/using-suppression/PR
branch
from
7b49a2b to
639c4ab
Compare
NthPortal
force-pushed
the
topic/using-suppression/PR
branch
from
639c4ab to
9763a18
Compare
Use granular hierarchy for exception suppression in `Using.resource`.
NthPortal
force-pushed
the
topic/using-suppression/PR
branch
from
9763a18 to
f1ef66c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use granular hierarchy for exception suppression in
Using.resource.The motivation for this PR is that it seemed odd to me that a
NonLocalReturnControlshould be thrown in preference to aVirtualMachineError.