ControlThrowable never suppresses #7413
Conversation
|
For a more migration-friendly attempt at solving this problem, see #7165 Also, this fixes scala/bug#11116 |
|
@NthPortal thanks, obviously I didn't know you were already thinking about this. |
som-snytt
force-pushed
the
topic/ctl-throw
branch
from
d10d082 to
6d6e024
Compare
|
Obviously, I'm being very lazy about this (because I'm using my repo for a different PR): non-fatal-tests.scala:19: error: class ControlThrowable is abstract; cannot be instantiated |
som-snytt
force-pushed
the
topic/ctl-throw
branch
from
6d6e024 to
0cdd890
Compare
|
@NthPortal I tweaked the handling of |
som-snytt
force-pushed
the
topic/ctl-throw
branch
from
fdc426b to
0bc0323
Compare
This comment has been minimized.
This comment has been minimized.
NthPortal
left a comment
NthPortal
left a comment
There was a problem hiding this comment.
If it doesn't break known uses, I would prefer extending Throwable
|
Just to note: the purpose of the PR was to exploit the newer constructor, but that sacrifices flexibility of the mix-in. It might be desirable to have both a non-Exception and an Exceptional version.
It's obvious from the Scaladoc that it was originally intended as a marker only, for all sorts of throwables, but maybe that intention was never fully realized. The clean-up adjusts the constructor and the Scaladoc. |
som-snytt
force-pushed
the
topic/ctl-throw
branch
from
d698676 to
2805233
Compare
|
I think this is ready for merge once it's squashed? cc @SethTisue |
ControlThrowable never suppresses ControlThrowable stack trace can be writable Deprecate ControlThrowable with trace Assert order and message Test improvements ControlThrowable is not exceptional Since ControlThrowable is now more opinionated, just make it a Throwable, following the adage that Exceptions are for exceptional conditions. Update the doc to use NonFatal when catching, as the previous example contended with ControlThrowable mixed into arbitrary exceptions.
som-snytt
force-pushed
the
topic/ctl-throw
branch
from
2805233 to
bd368a7
Compare
6 participants
Make ControlThrowable a class with suppression and stack trace disabled.
This change would affect anyone mixing the trait into a custom Error or checked exception.