Skip to content

Upgrade to ASM 7 for improved JDK 12 compat #7384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SethTisue merged 2 commits into from
Dec 4, 2018
Merged

Upgrade to ASM 7 for improved JDK 12 compat #7384

SethTisue merged 2 commits into from
Dec 4, 2018

Conversation

@lrytz
Copy link
Member

@lrytz lrytz commented Nov 1, 2018 •
edited by SethTisue
Loading

improves compatibility with JDK 12

@scala-jenkins scala-jenkins added this to the 2.13.0-RC1 milestone Nov 1, 2018
@lrytz lrytz requested a review from retronym November 1, 2018 11:30
@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Nov 1, 2018
@lrytz lrytz mentioned this pull request Nov 5, 2018
Merged
@xuwei-k xuwei-k mentioned this pull request Nov 6, 2018
Closed
3 tasks
@SethTisue
Copy link
Member

SethTisue commented Nov 6, 2018

release-notes-able, I think. if this resolves any known issues or improves JDK 11 (or 9+) compat, could you say so in the PR description...?

@SethTisue

This comment has been minimized.

Sign in to view
@mkurz

This comment has been minimized.

Sign in to view
@SethTisue SethTisue closed this Nov 6, 2018
@SethTisue SethTisue reopened this Nov 6, 2018
@SethTisue

This comment has been minimized.

Sign in to view
@SethTisue
Copy link
Member

SethTisue commented Nov 6, 2018 •
edited
Loading

sigh. as for the Travis-CI failure,

[warn] there were 475 inliner warnings; re-run enabling -opt-warnings for details, or try -help
[warn] 8 warnings found
[error] ## Exception when compiling 161 sources to /home/travis/build/scala/scala/build/quick/classes/reflect
[error] null
[error] scala.reflect.internal.transform.Erasure.transformInfo(Erasure.scala:395)
[error] scala.reflect.internal.transform.Erasure.transformInfo$(Erasure.scala:389)
[error] scala.tools.nsc.transform.Erasure.transformInfo(Erasure.scala:22)
[error] scala.tools.nsc.transform.InfoTransform$Phase$$anon$1.transform(InfoTransform.scala:45)
[error] scala.reflect.internal.Symbols$Symbol.rawInfo(Symbols.scala:1634)
[error] scala.reflect.internal.Symbols$Symbol.info(Symbols.scala:1551)
[error] scala.reflect.internal.Symbols$Symbol.tpeHK(Symbols.scala:1476)
[error] scala.reflect.internal.Types$Type.computeMemberType(Types.scala:736)
[error] scala.reflect.internal.Types$Type.memberType(Types.scala:733)
[error] scala.tools.nsc.typechecker.Infer$Inferencer.checkAccessible(Infer.scala:298)
[error] scala.tools.nsc.typechecker.Typers$Typer.makeAccessible(Typers.scala:584)
[error] scala.tools.nsc.typechecker.Typers$Typer.typedIdent$2(Typers.scala:5207)
[error] scala.tools.nsc.typechecker.Typers$Typer.typedIdentOrWildcard$1(Typers.scala:5222)
[error] scala.tools.nsc.typechecker.Typers$Typer.typed1(Typers.scala:5673)
[error] scala.tools.nsc.transform.Erasure$Eraser.typed1(Erasure.scala:797)
[error] scala.tools.nsc.typechecker.Typers$Typer.typed(Typers.scala:5721)
[error] scala.tools.nsc.transform.Erasure$Eraser.adaptMember(Erasure.scala:722)
[error] scala.tools.nsc.transform.Erasure$Eraser.typed1(Erasure.scala:797)
[error] scala.tools.nsc.typechecker.Typers$Typer.typed(Typers.scala:5721)
[error] scala.tools.nsc.typechecker.Typers$Typer.$anonfun$typed1$39(Typers.scala:4795)
[error] scala.tools.nsc.typechecker.Typers$Typer.silent(Typers.scala:704)
[error] scala.tools.nsc.typechecker.Typers$Typer.normalTypedApply$1(Typers.scala:4797)
[error] scala.tools.nsc.typechecker.Typers$Typer.typedApply$1(Typers.scala:4825)

and many more such lines follow.

@lrytz
Copy link
Member Author

lrytz commented Nov 7, 2018

Rebased to include the Xss from #7392

@mkurz
Copy link
Contributor

mkurz commented Dec 3, 2018

Any chance to get this merged?

@SethTisue
Copy link
Member

SethTisue commented Dec 4, 2018

release-notes-able, I think. if this resolves any known issues or improves JDK 11 (or 9+) compat, could you say so in the PR description...?

@lrytz ping

@SethTisue SethTisue merged commit ad110da into scala:2.13.x Dec 4, 2018
@lrytz
Copy link
Member Author

lrytz commented Dec 5, 2018

I don't think there's a noticable change for users, it's mostly interesting for us because our fork is now very close to the official release.

@SethTisue SethTisue removed the release-notes worth highlighting in next release notes label Dec 5, 2018
@xuwei-k xuwei-k mentioned this pull request Jan 19, 2019
Closed
smarter added a commit to dotty-staging/dotty that referenced this pull request Feb 12, 2019
@smarter
Upgrade to ASM 7.0
7cb7c0e 
Catch up with Scala 2.13.

The corresponding scalac PRs are
scala/scala#6733 and
scala/scala#7384

Most of the changes from these PRs aren't currently needed in Dotty
since they only affect the Scala 2 backend optimizer.
@smarter smarter mentioned this pull request Feb 12, 2019
Merged
smarter added a commit to dotty-staging/dotty that referenced this pull request Feb 12, 2019
@smarter @retronym
Upgrade to ASM 7.0
61301d1 
Catch up with Scala 2.13.

The corresponding scalac PRs are
scala/scala#6733 and
scala/scala#7384

Some of the changes from these PRs aren't currently needed in Dotty
since they only affect the Scala 2 backend optimizer.

Co-Authored-By: Jason Zaugg <[email protected]>
smarter added a commit to dotty-staging/dotty that referenced this pull request Feb 12, 2019
@smarter @retronym
Upgrade to ASM 7.0
0abd076 
Catch up with Scala 2.13.

The corresponding scalac PRs are
scala/scala#6733 and
scala/scala#7384

Some of the changes from these PRs aren't currently needed in Dotty
since they only affect the Scala 2 backend optimizer.

This update does not change the generated bytecode (at least when
compiling dotty itself).

Co-Authored-By: Jason Zaugg <[email protected]>
@SethTisue SethTisue mentioned this pull request Feb 21, 2019
Closed
@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Feb 21, 2019
@SethTisue
Copy link
Member

SethTisue commented Feb 21, 2019

as per scala/community-build#864 and scala/bug#11372, this improves JDK 12 compat (projects that don't compile on JDK 12 on 2.13.0-M5 do compile on recently nightlies that include this PR), so I've added the release-notes tag and updated the PR description to say "improves compatibility with JDK 12"

@SethTisue SethTisue mentioned this pull request Feb 22, 2019
Merged
@SethTisue
Copy link
Member

SethTisue commented Feb 22, 2019

submitted 2.12.x back port at #7780

@SethTisue SethTisue changed the title Upgrade to ASM 7 Upgrade to ASM 7 for improved JDK 12 compat Apr 4, 2019
@mkurz
Copy link
Contributor

mkurz commented Apr 13, 2019

ASM 7.1 released, includes bug fixes: https://asm.ow2.io/versions.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@retronym retronym Awaiting requested review from retronym

Assignees

No one assigned

Labels

release-notes worth highlighting in next release notes

Projects

None yet

Milestone

2.13.0-RC1

Development

Successfully merging this pull request may close these issues.

4 participants

@lrytz @SethTisue @mkurz @scala-jenkins