Restore and use linesIterator to avoid conflict with JDK 11's String.lines #7269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Fixes scala/bug#11125 |
retronym
force-pushed
the
topic/restore-lines-iterator-2.13
branch
from
13bdcc4 to
83c5504
Compare
retronym
force-pushed
the
topic/restore-lines-iterator-2.13
branch
from
83c5504 to
b43cd95
Compare
xuwei-k
approved these changes
Sep 27, 2018
SethTisue
requested changes
Sep 27, 2018
Member
SethTisue
left a comment
SethTisue
left a comment
There was a problem hiding this comment.
one suggested change, otherwise LGTM for merge
Which was added in JDK 11.
retronym
force-pushed
the
topic/restore-lines-iterator-2.13
branch
from
b43cd95 to
4dcc5c0
Compare
SethTisue
approved these changes
Sep 27, 2018
retronym
added a commit
to retronym/scala
that referenced
this pull request
Sep 9, 2019
Mostly a no-op as 2.13.x already had the same changes applied in scala#7269 and others.
ioannakok
added a commit
to guardian/frontend
that referenced
this pull request
Aug 23, 2022
`lines` is not a method of `WrappedString` anymore but we can call `linesIterator` on a String after it has been undeprecated in this PR: scala/scala#7269 This way we get rid of the following error: ``` [error] /Users/Ioanna_Kokkini/Projects/frontend/common/app/common/TrailsToShowcase.scala:509:46: value lines is not a member of scala.collection.immutable.WrappedString [error] val lines = new WrappedString(trailText).lines.toSeq [error] ^ [error] one error found ```
ioannakok
added a commit
to guardian/frontend
that referenced
this pull request
Aug 23, 2022
`lines` is not a method of `WrappedString` anymore but we can call `linesIterator` on a String after it has been undeprecated in this PR: scala/scala#7269 This way we get rid of the following error: ``` [error] /Users/Ioanna_Kokkini/Projects/frontend/common/app/common/TrailsToShowcase.scala:509:46: value lines is not a member of scala.collection.immutable.WrappedString [error] val lines = new WrappedString(trailText).lines.toSeq [error] ^ [error] one error found ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.