Avoid scala runtime reflection in Html Tags DSL #7242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@retronym I've noticed that productElementNames was already part of M5, so I hope you don't mind that I implemented a ticket you assinged yourself. let me know if this was all you had in mind! |
Member
Not at all! Thank you. |
retronym
approved these changes
Sep 20, 2018
Member
retronym
left a comment
retronym
left a comment
There was a problem hiding this comment.
I manually checked the HTML output of Scaladoc, including the recent changes to add support for tables. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/scala-dev#560