Make scala.collection.AnyConstr private #7077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Member
|
@smarter is there a need to get this into M5, or is RC1 okay? |
It exists only for cross-compiling the library between Scala 2 and Dotty and is not supposed to be used directly.
szeiger
force-pushed
the
issue/private-anyconstr
branch
from
6ed3b35 to
7e8242a
Compare
Contributor
Author
|
We shouldn't expose |
lrytz
approved these changes
Aug 16, 2018
szeiger
added a commit
to szeiger/scala
that referenced
this pull request
Dec 7, 2018
This also provides a nice solution for AnyConstr (see scala#7077 and scala#7072): We simply don’t need it anymore.
szeiger
added a commit
to szeiger/scala
that referenced
this pull request
Dec 11, 2018
This also provides a nice solution for AnyConstr (see scala#7077 and scala#7072): We simply don’t need it anymore. We really want to constrain both IterableCC and MapCC to Iterable (the latter because it’s needed for MapView) but that causes collisions after erasure, so we have to go back to IterableOnce for IterableCC. Using something more specific (like MapOps with Iterable) for MapCC is not possible because in MapView the MapCC is not actually MapView but only View.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It exists only for cross-compiling the library between Scala 2 and Dotty
and is not supposed to be used directly.