Deal with numeric but singleton typed numeric fields #7070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following on from scala#5536 this commit adds another fields.castHack in AccessorSynthesis#expandLazyClassMember to deal with numeric but singleton typed numeric fields which would otherwise be widened by numericLub. Fixes scala/bug#11071.
This was referenced Aug 14, 2018
Member
|
can this wait til RC1? we're trying hard to lock M5 down so we can build it tomorrow or Friday |
Contributor
Author
|
I think it's low risk and it'd be better to have it in sooner rather than later. The fact that something like tap tickled it suggests it's probably needed. |
retronym
approved these changes
Aug 16, 2018
Member
retronym
left a comment
retronym
left a comment
There was a problem hiding this comment.
This looks pretty safe to me. Let's M5 it
SethTisue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #5536 this commit adds another
fields.castHackinAccessorSynthesis#expandLazyClassMemberto deal with numeric but singleton typed numeric fields which would otherwise be widened bynumericLub.Fixes scala/bug#11071.