Copy arrays that are explicitly passed as varargs with : _*
#6970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
What happens when one passes an |
Contributor
Author
|
Java varargs are unaffected, all arrays are passed unmodified. |
This operation is deprecated and produces a deprecation warning similar to the one for `Predef.copyArrayToImmutableIndexedSeq.` which serves the same purpose for the non-varargs case.
Member
|
fine w/ me. I say we merge this for M5. @lrytz have you been following this? tentatively assigning to you for final signoff. |
SethTisue
added
the
prio:blocker
lrytz
reviewed
Aug 7, 2018
Member
lrytz
left a comment
lrytz
left a comment
There was a problem hiding this comment.
LGTM otherwise. I also think this is the right step.
| // collections classes | ||
| private[this] lazy val isNewCollections = getClassIfDefined("scala.collection.IterableOnce") != NoSymbol | ||
| private[this] lazy val _isNewCollections = getClassIfDefined("scala.collection.IterableOnce") != NoSymbol | ||
| private[scala] def isNewCollections = _isNewCollections |
Member
There was a problem hiding this comment.
why not private[scala] lazy val ...? Or just make a public lazy val, we don't need to worry about visibility in reflect.internal.
Contributor
Author
There was a problem hiding this comment.
A non-private[this] val leaks into JavaUniverseForce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This operation is deprecated and produces a deprecation warning similar
to the one for
Predef.copyArrayToImmutableIndexedSeq.which serves thesame purpose for the non-varargs case.
Fixes scala/bug#11024