Enforce explicit return type for macros [ci: last-only] #6942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous warning already expired. Fix offending tests.
adriaanm
approved these changes
Aug 3, 2018
Contributor
|
@SethTisue could you coordinate merging this based on the community build? |
Member
|
the run shows that scalatest and specs2 need updating for this, and then probably other projects downstream, too. let's take care of it after M5 is out the door |
SethTisue
added
the
prio:blocker
Member
|
I'll deal with the community build breakage, gradually. |
xuwei-k
added a commit
to xuwei-k/specs2
that referenced
this pull request
Aug 31, 2018
etorreborre
pushed a commit
to etorreborre/specs2
that referenced
this pull request
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous warning already expired.
Fix offending tests.
Apologies in advance if there's a good reason the stern warning was never followed up.